From: Oleg Nesterov <oleg@redhat.com>
To: Kirill Tkhai <ktkhai@parallels.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
tkhai@yandex.ru
Subject: Re: [PATCH] de_thread: Move notify_count write under lock
Date: Thu, 5 Feb 2015 18:18:59 +0100 [thread overview]
Message-ID: <20150205171858.GA17659@redhat.com> (raw)
In-Reply-To: <1423152711.6933.19.camel@tkhai>
On 02/05, Kirill Tkhai wrote:
>
> Other solution is in the patch below.
I like your previous patch more ;)
> Can't (sig->notify_count == -1) be visible earlier than tsk->signal->group_exit_task
> in exit_notify()?
Yes, please see another email I sent. Sorry again for missing your point.
> tasklist_lock is held in exit_notify(), but de_thread() actions (notify_count and
> group_exit_task writes) are independent from it (another lock is held there).
^^^^^^^^^^^^^^^^^^^^^^^^^^
Yes, I missed this.
Oleg.
next prev parent reply other threads:[~2015-02-05 17:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 13:13 [PATCH] de_thread: Move notify_count write under lock Kirill Tkhai
2015-02-05 13:38 ` Oleg Nesterov
2015-02-05 14:15 ` Kirill Tkhai
2015-02-05 14:27 ` Kirill Tkhai
2015-02-05 17:09 ` Oleg Nesterov
2015-02-05 16:11 ` Kirill Tkhai
2015-02-05 16:49 ` Kirill Tkhai
2015-02-05 17:18 ` Oleg Nesterov [this message]
2015-02-23 20:18 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150205171858.GA17659@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ktkhai@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tkhai@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox