From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753787AbbBEWal (ORCPT <rfc822;w@1wt.eu>);
	Thu, 5 Feb 2015 17:30:41 -0500
Received: from zeniv.linux.org.uk ([195.92.253.2]:50374 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751079AbbBEWak (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 5 Feb 2015 17:30:40 -0500
Date: Thu, 5 Feb 2015 22:30:39 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 1/7] trace: fix the glob match in
 __unregister_ftrace_function_probe()
Message-ID: <20150205223038.GV29656@ZenIV.linux.org.uk>
References: <20150205194914.GR29656@ZenIV.linux.org.uk>
 <1423166200-1800-1-git-send-email-viro@ZenIV.linux.org.uk>
 <20150205154336.0be014e9@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150205154336.0be014e9@gandalf.local.home>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 05, 2015 at 03:43:36PM -0500, Steven Rostedt wrote:
> Can you make search = NULL instead of glob at the start of the
> function. That is:
> 
> 	if (!glob || strcmp(glob, "*") == 0 || !strlen(glob))
> 		search = NULL;

Umm...  If we do it that way, I'd rather initialized search with NULL
and inverted the test:
	if (glob && *glob && strcmp(glob, "*") != 0) {
		parse it and set search
	}