From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752485AbbBEWqg (ORCPT <rfc822;w@1wt.eu>);
	Thu, 5 Feb 2015 17:46:36 -0500
Received: from zeniv.linux.org.uk ([195.92.253.2]:50488 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751153AbbBEWqe (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 5 Feb 2015 17:46:34 -0500
Date: Thu, 5 Feb 2015 22:46:32 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 5/7] trace: make filter_parse_regex() provide the
 length of substring to compare with
Message-ID: <20150205224632.GW29656@ZenIV.linux.org.uk>
References: <20150205194914.GR29656@ZenIV.linux.org.uk>
 <1423166200-1800-5-git-send-email-viro@ZenIV.linux.org.uk>
 <20150205162933.4fad48f6@gandalf.local.home>
 <20150205214424.GS29656@ZenIV.linux.org.uk>
 <20150205170743.3c34178f@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150205170743.3c34178f@gandalf.local.home>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 05, 2015 at 05:07:43PM -0500, Steven Rostedt wrote:
> On Thu, 5 Feb 2015 21:44:24 +0000
> Al Viro <viro@ZenIV.linux.org.uk> wrote:
> 
> 
> > The point is that by now this strlen() is the only thing for which we
> > NUL-termination of the substring; moving it inside the filter_parse_regex()
> > is an obviously equivalent transformation and it leaves that one strlen() call
> > inside filter_parse_regex() the only place where we still care about NUL.
> > 
> > The next commit kills it off completely, at which point we are done with
> > modifying the string at all.
> 
> Thanks for the explanation,
> 
> Can you add that to the change log. I like to think patches can stand
> on their own, and if they are added to help another patch, it should be
> stated in the change log so someone doing a git blame followed by a git
> show, knows what is going on.

Done and force-pushed.  Do you want me to repost the whole thing?