From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752937AbbBFNg7 (ORCPT ); Fri, 6 Feb 2015 08:36:59 -0500 Received: from hofr.at ([212.69.189.236]:36472 "EHLO mail.hofr.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750760AbbBFNg6 (ORCPT ); Fri, 6 Feb 2015 08:36:58 -0500 Date: Fri, 6 Feb 2015 14:36:56 +0100 From: Nicholas Mc Guire To: Sergei Shtylyov Cc: Nicholas Mc Guire , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: image: use msecs_to_jiffies for time conversion Message-ID: <20150206133656.GA29868@opentech.at> References: <1423216221-29094-1-git-send-email-hofrat@osadl.org> <54D4B34B.7030408@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54D4B34B.7030408@cogentembedded.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 06 Feb 2015, Sergei Shtylyov wrote: > Hello. > > On 2/6/2015 12:50 PM, Nicholas Mc Guire wrote: > >> This is only an API consolidation and should make things more readable >> it replaces var * HZ / 1000 by msecs_to_jiffies(var). > >> Signed-off-by: Nicholas Mc Guire >> --- > >> Note that the indentation is not aligned with the correct ( here due to >> lines going over 80 char - not sure if this is the right way to resolve >> this (this file has quite a few coding style issues). > >> Patch was only compile tested with x86_64_defconfig + CONFIG_USB_MDC800=m > >> Patch is against 3.19.0-rc7 (localversion-next is -next-20150204) > >> drivers/usb/image/mdc800.c | 11 +++++++---- >> 1 file changed, 7 insertions(+), 4 deletions(-) > >> diff --git a/drivers/usb/image/mdc800.c b/drivers/usb/image/mdc800.c >> index a62865a..3a72e8f 100644 >> --- a/drivers/usb/image/mdc800.c >> +++ b/drivers/usb/image/mdc800.c > [...] >> @@ -743,8 +744,9 @@ static ssize_t mdc800_device_read (struct file *file, char __user *buf, size_t l >> mutex_unlock(&mdc800->io_lock); >> return len-left; >> } >> - wait_event_timeout(mdc800->download_wait, mdc800->downloaded, >> - TO_DOWNLOAD_GET_READY*HZ/1000); >> + wait_event_timeout(mdc800->download_wait, >> + mdc800->downloaded, >> + msecs_to_jiffies(TO_DOWNLOAD_GET_READY)); > > Don't indent with spaces (you're not aligning to open paren anyway), > use the final tab instead, please. > thanks ! In the diff output that problem is actually not well visible. was not really clear on how to do this properly - the problem with using the last tab stop is that you then get the following code wait_event_timeout(mdc800->download_wait, mdc800->downloaded, msecs_to_jiffies(TO_DOWNLOAD_GET_READY)); mdc800->downloaded = 0; which semed really bad and wait_event_timeout(mdc800->download_wait, mdc800->downloaded, msecs_to_jiffies(TO_DOWNLOAD_GET_READY)); mdc800->downloaded = 0; makes it atleast somewhat readable. If I indent a full tab ghen it goes over 80 char. So in this case - should one use the last tab-stop anyway ? thx! hofrat