From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753321AbbBFTVY (ORCPT ); Fri, 6 Feb 2015 14:21:24 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:37248 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751421AbbBFTVX (ORCPT ); Fri, 6 Feb 2015 14:21:23 -0500 Date: Fri, 6 Feb 2015 20:21:21 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Stefan Agner Cc: linus.walleij@linaro.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, kernel@pengutronix.de, shawn.guo@linaro.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] pinctrl: imx: do not implicitly set pin regs to -1 Message-ID: <20150206192121.GD10842@pengutronix.de> References: <1423240256-27210-1-git-send-email-stefan@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1423240256-27210-1-git-send-email-stefan@agner.ch> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hallo Stefan, On Fri, Feb 06, 2015 at 05:30:56PM +0100, Stefan Agner wrote: > - memset(info->pin_regs, 0xff, sizeof(*info->pin_regs) * info->npins); > + > + for (i = 0; i < info->npins; i++) { > + info->pin_regs[i].mux_reg = -1; > + info->pin_regs[i].conf_reg = -1; > + } looks definitely better. Just out of interest, did you check if it changes the generated code? Acked-by: Uwe Kleine-König Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |