From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757937AbbBFUIH (ORCPT ); Fri, 6 Feb 2015 15:08:07 -0500 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.230]:20648 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753938AbbBFUIE (ORCPT ); Fri, 6 Feb 2015 15:08:04 -0500 Message-Id: <20150206200653.009919583@goodmis.org> User-Agent: quilt/0.61-1 Date: Fri, 06 Feb 2015 15:06:53 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: "Paul E. McKenney" , Dave Hansen , "Rafael J. Wysocki" , linux-next , Stephen Rothwell , Kristen Carlson Accardi , "H. Peter Anvin" , Rik van Riel , Mel Gorman , Andrew Morton Subject: [PATCH 0/2] tracing/tlb/x85: Fix splat of calling RCU trace code on offline CPU X-RR-Connecting-IP: 107.14.168.142:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paul, I found a much better fix than adding the rcu_nocheck(). Simply have the rcu check inside the condition check as well. This way the rcu splat will only happen if the condition is set too. The condition doesn't need the tracepoint enabled. Now I'm thinking that I should push the first patch through my tree as it only touches tracing. The second patch you can freely take. Neither patch really depends on the other, but both patches are required to make the splat go away. If Sedat could test these patches together, and give his tested-by tag, that would be great. I'll run my patch through my full series of tests and then push to linux next. You could take the second patch and push that through your tree (linux-next). When both arrive, the bug will be fixed. The two do not need to come in together. Thoughts? -- Steve Steven Rostedt (Red Hat) (2): tracing: Add condition check to RCU lockdep checks x86/tbl/trace: Do not trace on CPU that is offline ---- include/linux/tracepoint.h | 2 +- include/trace/events/tlb.h | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-)