From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757897AbbBFVRN (ORCPT ); Fri, 6 Feb 2015 16:17:13 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:44927 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757211AbbBFVRL (ORCPT ); Fri, 6 Feb 2015 16:17:11 -0500 Date: Fri, 6 Feb 2015 22:17:08 +0100 From: Pavel Machek To: Joe Perches Cc: Quentin Lambert , Ming Lei , Greg Kroah-Hartman , "Rafael J. Wysocki" , Len Brown , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 1/1] drivers/base: Remove unnecessary OOM message Message-ID: <20150206211708.GA25967@amd> References: <20150206153912.GA8486@sloth> <20150206205852.GA14126@amd> <1423256670.4752.16.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423256670.4752.16.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 2015-02-06 13:04:30, Joe Perches wrote: > On Fri, 2015-02-06 at 21:58 +0100, Pavel Machek wrote: > > On Fri 2015-02-06 16:39:12, Quentin Lambert wrote: > > > This patch fix checkpatch warnings concerning the possible > > > duplication of an "out of memory" message. > > > > So, instead of nice and readable "not enough memory for clock..." we > > get OOM, stackdump, and backtrace...? Not sure it is improvement. > > All allocs without __GFP_NOWARN already gets an OOM and stackdump. > These are just unnecessary. "These" being human readable messages or ugly stackdumps? Read what I have said. Figuring out what allocation failed from unreliable backtrace is not fun. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html