From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753491AbbBGKZK (ORCPT ); Sat, 7 Feb 2015 05:25:10 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:38128 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751813AbbBGKZI (ORCPT ); Sat, 7 Feb 2015 05:25:08 -0500 Date: Sat, 7 Feb 2015 13:24:36 +0300 From: Dan Carpenter To: Pavel Machek Cc: Joe Perches , Quentin Lambert , Ming Lei , Greg Kroah-Hartman , "Rafael J. Wysocki" , Len Brown , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 1/1] drivers/base: Remove unnecessary OOM message Message-ID: <20150207102436.GB5206@mwanda> References: <20150206153912.GA8486@sloth> <20150206205852.GA14126@amd> <1423256670.4752.16.camel@perches.com> <20150206211708.GA25967@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150206211708.GA25967@amd> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Facts: 1) None of these four error messages will ever be printed. http://lwn.net/Articles/627419/ 2) These messages are a waste of RAM. Debatable: 1) These messages are bad style and distracting. Simple code is better. 2) The normal OOM message is enough to find which allocation failed. Not everbody, but a lot of people write these kinds of error messages with their brain on auto-pilot because they think they *should* do it. It's quite common to do things like printk("dev is NULL. %s", dev->name);. I'm happy for this checkpatch warning because it hopefully bumps people out of mindless mode and makes them think about error messages. regards, dan carpenter