From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755386AbbBHLBV (ORCPT ); Sun, 8 Feb 2015 06:01:21 -0500 Received: from mail-pd0-f172.google.com ([209.85.192.172]:40208 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755001AbbBHLBU (ORCPT ); Sun, 8 Feb 2015 06:01:20 -0500 Date: Sun, 8 Feb 2015 16:31:07 +0530 From: Sudip Mukherjee To: Greg Kroah-Hartman Cc: Benjamin Romer , David Kershner , devel@driverdev.osuosl.org, sparmaintainer@unisys.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: unisys: remove unused variable Message-ID: <20150208110107.GA4091@sudip-PC> References: <1423226603-5443-1-git-send-email-sudipm.mukherjee@gmail.com> <20150207092216.GB21816@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150207092216.GB21816@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 07, 2015 at 05:22:16PM +0800, Greg Kroah-Hartman wrote: > On Fri, Feb 06, 2015 at 06:13:21PM +0530, Sudip Mukherjee wrote: > > we were getting lots of warnings about _tempresult set but not used. > > _tempresult was used in the macro ISSUE_IO_VMCALL_POSTCODE_SEVERITY > > which was again using another macro ISSUE_IO_EXTENDED_VMCALL. > > but the vallue assigned to it was never used. > > > > Signed-off-by: Sudip Mukherjee > > Your From: address, and this address don't match, so I can't take this > :( all my patches have been like this way, and you have taken them before :) the reason its like this way - (already discussed with Dan Carpenter, reference https://lkml.org/lkml/2014/9/3/473) we have strict DMARC check for the corporate mail server. DMARC = domain based message authentication. So the mail i sent reached all the list subscriber from a different server than our designated server, and as a result it is marked as spam in many places and I have already received a few complaints regarding that. so at https://lkml.org/lkml/2014/9/3/535 Dan said its ok for him, but depends on you if you want to accept. And since you have accepted all my patches before so i thought it is ok with you. if you want I can add an extra From: line, but Dan has already given his commments for that at https://lkml.org/lkml/2014/9/3/135 quoting him : "If everyone starts using From headers like this then it becomes a pain to deal with." please let me know how you want me to send the patches if different email address is a problem. I thought different name is a problem, but different email address??? > > Fix that up please and resend. > > Also, what tool generated those warnings? just make W=1 will give these warnings. regards sudip > > thanks, > > greg k-h