* [PATCH] gpsca: remove the risk of a division by zero
@ 2015-02-09 10:16 Luis de Bethencourt
2015-02-09 10:18 ` Luis de Bethencourt
0 siblings, 1 reply; 2+ messages in thread
From: Luis de Bethencourt @ 2015-02-09 10:16 UTC (permalink / raw)
To: linux-media; +Cc: mchehab, hdegoede, linux-kernel
As reported by Peter Kovar, there's a potential risk of a division by zero on
calls to jpeg_set_qual() when quality is zero.
As quality can't be 0 or lower than that, add an extra clause to cover this
special case.
Signed-off-by: Luis de Bethencourt <luis.bg@samsung.com>
---
drivers/media/usb/gspca/topro.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/usb/gspca/topro.c b/drivers/media/usb/gspca/topro.c
index 5fcd1ee..c70ff40 100644
--- a/drivers/media/usb/gspca/topro.c
+++ b/drivers/media/usb/gspca/topro.c
@@ -969,7 +969,9 @@ static void jpeg_set_qual(u8 *jpeg_hdr,
{
int i, sc;
- if (quality < 50)
+ if (quality <= 0)
+ sc = 5000;
+ else if (quality < 50)
sc = 5000 / quality;
else
sc = 200 - quality * 2;
--
2.1.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpsca: remove the risk of a division by zero
2015-02-09 10:16 [PATCH] gpsca: remove the risk of a division by zero Luis de Bethencourt
@ 2015-02-09 10:18 ` Luis de Bethencourt
0 siblings, 0 replies; 2+ messages in thread
From: Luis de Bethencourt @ 2015-02-09 10:18 UTC (permalink / raw)
To: linux-media; +Cc: mchehab, hdegoede, linux-kernel
On Mon, Feb 09, 2015 at 10:16:25AM +0000, Luis de Bethencourt wrote:
> As reported by Peter Kovar, there's a potential risk of a division by zero on
> calls to jpeg_set_qual() when quality is zero.
>
> As quality can't be 0 or lower than that, add an extra clause to cover this
> special case.
>
> Signed-off-by: Luis de Bethencourt <luis.bg@samsung.com>
> ---
> drivers/media/usb/gspca/topro.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/gspca/topro.c b/drivers/media/usb/gspca/topro.c
> index 5fcd1ee..c70ff40 100644
> --- a/drivers/media/usb/gspca/topro.c
> +++ b/drivers/media/usb/gspca/topro.c
> @@ -969,7 +969,9 @@ static void jpeg_set_qual(u8 *jpeg_hdr,
> {
> int i, sc;
>
> - if (quality < 50)
> + if (quality <= 0)
> + sc = 5000;
> + else if (quality < 50)
> sc = 5000 / quality;
> else
> sc = 200 - quality * 2;
> --
> 2.1.3
>
Reported here:
http://www.mail-archive.com/linux-media@vger.kernel.org/msg84989.html
Thanks :)
Luis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-09 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-09 10:16 [PATCH] gpsca: remove the risk of a division by zero Luis de Bethencourt
2015-02-09 10:18 ` Luis de Bethencourt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox