public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "<gregkh@linuxfoundation.org>" <gregkh@linuxfoundation.org>
To: Tal Shorer <tal.shorer@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	"<devel@driverdev.osuosl.org>" <devel@driverdev.osuosl.org>,
	"Dilger, Andreas" <andreas.dilger@intel.com>,
	"<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>,
	"Drokin, Oleg" <oleg.drokin@intel.com>,
	"<clabbe.montjoie@gmail.com>" <clabbe.montjoie@gmail.com>
Subject: Re: [PATCH v3] staging: lustre: fix coding style errors
Date: Tue, 10 Feb 2015 05:34:08 +0800	[thread overview]
Message-ID: <20150209213408.GA11071@kroah.com> (raw)
In-Reply-To: <CAFDyS3P2Fbg4kawfs7dVOUhc71P8yC2jssjTpzGJFbdfcca1HA@mail.gmail.com>

On Mon, Feb 09, 2015 at 07:20:30PM +0200, Tal Shorer wrote:
> Fix the following coding style errors in
> drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c:
> 1. initializing lnet_table_header (static pointer) to NULL
> 2. missing spaces around '='

Those are two different things, and should be 2 different patches.
Please split up and resend that way.

> There's a third coding style error in this file which I've chosen to
> not fix for clarity's sake. It is: initializing min_watchdog_ratelimit
> (static int) to 0

Please fix that too, it's not correct.  Drop the comment there if you
think that's confusing.

thanks,

greg k-h

  reply	other threads:[~2015-02-09 21:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-09 17:20 [PATCH v3] staging: lustre: fix coding style errors Tal Shorer
2015-02-09 21:34 ` <gregkh@linuxfoundation.org> [this message]
2015-02-10  0:34   ` Drokin, Oleg
2015-02-10  0:52     ` <gregkh@linuxfoundation.org>

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150209213408.GA11071@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andreas.dilger@intel.com \
    --cc=clabbe.montjoie@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    --cc=tal.shorer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox