Re: [PATCH 1/2] staging: unisys: remove unused variable

Greg Kroah-Hartman
2015-02-09T21:35:45Z

On Sun, Feb 08, 2015 at 04:31:07PM +0530, Sudip Mukherjee wrote:
> On Sat, Feb 07, 2015 at 05:22:16PM +0800, Greg Kroah-Hartman wrote:
> > On Fri, Feb 06, 2015 at 06:13:21PM +0530, Sudip Mukherjee wrote:
> > > we were getting lots of warnings about _tempresult set but not used.
> > > _tempresult was used in the macro ISSUE_IO_VMCALL_POSTCODE_SEVERITY
> > > which was again using another macro ISSUE_IO_EXTENDED_VMCALL.
> > > but the vallue assigned to it was never used.
> > >
> > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> >
> > Your From: address, and this address don't match, so I can't take this
> > :(
>
> all my patches have been like this way, and you have taken them before :)
> the reason its like this way - (already discussed with Dan Carpenter, reference https://lkml.org/lkml/2014/9/3/473)
>
> we have strict DMARC check for the corporate mail server. DMARC = domain based message authentication.
> So the mail i sent reached all the list subscriber from a different server than our designated server,
> and as a result it is marked as spam in many places and I have already received a few complaints regarding that.
>
> so at https://lkml.org/lkml/2014/9/3/535 Dan said its ok for him, but depends on you if you want to accept.
> And since you have accepted all my patches before so i thought it is ok with you.

I didn't notice it before, sorry.

> if you want I can add an extra From: line, but Dan has already given his commments for that at https://lkml.org/lkml/2014/9/3/135
> quoting him :
>
> "If everyone starts using From headers like this then it becomes a pain to deal with."

It's not a pain to deal with on my end at all.

But as I've missed this in the past, nevermind, I'll take it as is. Can
you resend your outstanding patches and I'll queue them up after
3.20-rc1 is out.

thanks,

greg k-h