From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754889AbbBJKNW (ORCPT ); Tue, 10 Feb 2015 05:13:22 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:26029 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754836AbbBJKNS (ORCPT ); Tue, 10 Feb 2015 05:13:18 -0500 Date: Tue, 10 Feb 2015 13:13:12 +0300 From: Dan Carpenter To: Quentin Lambert Cc: Shigekatsu Tateno , Greg Kroah-Hartman , devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] staging: ozwpan: Remove allocation from delaration line Message-ID: <20150210101312.GG5206@mwanda> References: <20150210092412.GA12753@sloth> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150210092412.GA12753@sloth> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good. Thanks! > diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c > index 8543bb2..96e95bf 100644 > --- a/drivers/staging/ozwpan/ozhcd.c > +++ b/drivers/staging/ozwpan/ozhcd.c > @@ -280,8 +280,9 @@ static void oz_free_urb_link(struct oz_urb_link *urbl) > */ > static struct oz_endpoint *oz_ep_alloc(int buffer_size, gfp_t mem_flags) > { > - struct oz_endpoint *ep = > - kzalloc(sizeof(struct oz_endpoint)+buffer_size, mem_flags); > + struct oz_endpoint *ep; > + > + ep = kzalloc(sizeof(struct oz_endpoint)+buffer_size, mem_flags); > if (ep) { Also notice how in the original code, we had to mangle the code to make it fit into 80 characters so the new code looks much better. regards, dan carpenter