From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753004AbbBJRLu (ORCPT ); Tue, 10 Feb 2015 12:11:50 -0500 Received: from mga14.intel.com ([192.55.52.115]:8795 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750729AbbBJRLt (ORCPT ); Tue, 10 Feb 2015 12:11:49 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,551,1418112000"; d="scan'208";a="683769989" Date: Tue, 10 Feb 2015 09:11:35 -0800 From: Andi Kleen To: Peter Zijlstra Cc: Andi Kleen , linux-kernel@vger.kernel.org, kan.liang@intel.com Subject: Re: [PATCH 1/3] perf, x86: Add new cache events table for Haswell Message-ID: <20150210171135.GL680@tassilo.jf.intel.com> References: <1423509466-24430-1-git-send-email-andi@firstfloor.org> <20150210103455.GX21418@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150210103455.GX21418@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Just in case someone is crazy enough to run a 32bit kernel on HSW, this > needs to be BIT_ULL() -- also for compile testing, gcc tends to complain > about things like (1UL << 32) for ILP32 targets. Ok. > Now the other tables create little helpers like: > > #define HSW_DMND_READ (HSW_DMND_DATA_RD) > #define HSW_DMND_WRITE (HSW_DMND_RFO) > > #define HSW_L3_ACCESS (HSW_ANY_RESPONSE) > #define HSW_L3_MISS (HSW_L3_MISS) > > And compose the tables values using those: > > HSW_DMND_READ|HSW_L3_ACCESS > > Please do so here too. I'm trying to stay with the official documented bit names. No such bit names exist. If we make up our own names nobody else can read it anymore. > > Now; when comparing these value to the SNB for example I note that you > include ANY_SNOOP and SUPPLIER_NONE in L3_ACCESS, SNB and other do not, > please explain. You're supposed to set a snoop and supplier qualifier. AFAIK SNB should set them too. It may work without them due to some quirk. -Andi -- ak@linux.intel.com -- Speaking for myself only