From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754870AbbBJW0e (ORCPT ); Tue, 10 Feb 2015 17:26:34 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:50905 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754138AbbBJW0d (ORCPT ); Tue, 10 Feb 2015 17:26:33 -0500 Date: Wed, 11 Feb 2015 06:26:27 +0800 From: Greg Kroah-Hartman To: Quentin Lambert Cc: Benjamin Romer , David Kershner , devel@driverdev.osuosl.org, sparmaintainer@unisys.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] staging: unisys: Remove allocation from declaration line Message-ID: <20150210222627.GC27072@kroah.com> References: <20150210130214.GA18429@sloth> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150210130214.GA18429@sloth> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 10, 2015 at 02:02:14PM +0100, Quentin Lambert wrote: > This patch removes allocation from declaration line because > people are known to gloss over declarations. Again, who are these lazy people, and why are they reading kernel code? Please, it's ok to allocate things in the declaration line, don't make these kinds of changes. greg k-h