From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: devel@driverdev.osuosl.org, gmate.amit@gmail.com,
gregkh@linuxfoundation.org, Bas Peters <baspeters93@gmail.com>,
linux-kernel@vger.kernel.org,
Pushpendra Singh <pushpendra.singh@smartplayin.com>,
manuel.schoelling@gmx.de,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: Re: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error
Date: Wed, 11 Feb 2015 13:51:22 +0300 [thread overview]
Message-ID: <20150211105122.GN5206@mwanda> (raw)
In-Reply-To: <1423647637.15343.16.camel@perches.com>
On Wed, Feb 11, 2015 at 01:40:37AM -0800, Joe Perches wrote:
> On Wed, 2015-02-11 at 11:33 +0300, Dan Carpenter wrote:
> > You can't fight checkpatch.pl.
>
> Sure you can, Ignore it whenever appropriate.
People will just keep sending patches until something gets merged.
It's rude to ignore patches and it's useless because people will just
send another email asking you "have you received my patch yet?". It
just creates a bigger fight.
Applying mediocre checkpatch cleanups takes less time and energy than
constantly fighting. It's easiest to not fight over stupid stuff and
just apply the patches. Plus it makes the patch senders happy and
that creates a happier community.
regards,
dan carpenter
next prev parent reply other threads:[~2015-02-11 10:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 13:02 [PATCH 1/6] staging: rt8188eu: hal: removed space before ',' Pushpendra Singh
2015-02-10 13:02 ` [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error Pushpendra Singh
2015-02-10 14:13 ` Sudip Mukherjee
2015-02-10 14:27 ` Bas Peters
2015-02-10 14:48 ` Sudip Mukherjee
2015-02-11 8:33 ` Dan Carpenter
2015-02-11 9:40 ` Joe Perches
2015-02-11 10:51 ` Dan Carpenter [this message]
2015-02-11 18:00 ` checkpatch induced patches Joe Perches
2015-02-11 18:36 ` Dan Carpenter
2015-02-11 20:02 ` Richard Weinberger
2015-02-11 20:20 ` Joe Perches
2015-02-11 20:24 ` Pavel Machek
2015-02-11 20:43 ` Joe Perches
2015-02-11 22:43 ` Dan Carpenter
2015-02-11 22:46 ` Richard Weinberger
2015-02-11 23:01 ` Joe Perches
2015-02-12 8:03 ` Sudip Mukherjee
2015-02-12 16:44 ` Kalle Valo
2015-02-10 22:25 ` [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error Greg KH
2015-02-10 13:02 ` [PATCH 3/6] staging: rtl8188eu: hal: removed unnecessary braces Pushpendra Singh
2015-02-10 13:02 ` [PATCH 4/6] staging: rtl8188eu: hal: added blank line after declarations Pushpendra Singh
2015-02-10 13:02 ` [PATCH 5/6] staging: rtl8188eu: hal: removed spaces at start of line Pushpendra Singh
2015-02-10 13:02 ` [PATCH 6/6] staging: rtl8188eu: hal: removed unnecessary parentheses Pushpendra Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150211105122.GN5206@mwanda \
--to=dan.carpenter@oracle.com \
--cc=baspeters93@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gmate.amit@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manuel.schoelling@gmx.de \
--cc=pushpendra.singh@smartplayin.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox