[PATCH] afs: inode: Replace rcu_assign_pointer() with RCU_INIT_POINTER()

[PATCH] afs: inode: Replace rcu_assign_pointer() with RCU_INIT_POINTER()

[Andreea-Cristina Bernat]

The use of "rcu_assign_pointer()" is NULLing out the pointer.
According to RCU_INIT_POINTER()'s block comment:
"1.   This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a
smaller overhead.

The following Coccinelle semantic patch was used:
@@
@@

- rcu_assign_pointer
+ RCU_INIT_POINTER
  (..., NULL)

Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
---
 fs/afs/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/afs/inode.c b/fs/afs/inode.c
index 2946712..6457621 100644
--- a/fs/afs/inode.c
+++ b/fs/afs/inode.c
@@ -445,7 +445,7 @@ void afs_evict_inode(struct inode *inode)
 
 	mutex_lock(&vnode->permits_lock);
 	permits = vnode->permits;
-	rcu_assign_pointer(vnode->permits, NULL);
+	RCU_INIT_POINTER(vnode->permits, NULL);
 	mutex_unlock(&vnode->permits_lock);
 	if (permits)
 		call_rcu(&permits->rcu, afs_zap_permits);
-- 
1.9.1

Re: [PATCH] afs: inode: Replace rcu_assign_pointer() with RCU_INIT_POINTER()

[David Howells]

I've applied these two patches, but one of them throws up a problem in
Fengguang's magic auto-compilation thing.

David

Re: [PATCH] afs: inode: Replace rcu_assign_pointer() with RCU_INIT_POINTER()

[Paul E. McKenney]

On Wed, Feb 11, 2015 at 12:57:39PM +0000, David Howells wrote:
> I've applied these two patches, but one of them throws up a problem in
> Fengguang's magic auto-compilation thing.

Hello, David,

I seem to have fat-fingered Fengguang's magic auto-compilation thing's
email.  (One of those mornings, I guess...)  Could you please point me
at it?

							Thanx, Paul