From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753916AbbBKSLq (ORCPT ); Wed, 11 Feb 2015 13:11:46 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:48009 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753632AbbBKSLo (ORCPT ); Wed, 11 Feb 2015 13:11:44 -0500 Date: Wed, 11 Feb 2015 19:11:42 +0100 From: Pavel Machek To: Dmitry Torokhov Cc: Samuel Thibault , David Herrmann , akpm@linux-foundation.org, jslaby@suse.cz, Bryan Wu , rpurdie@rpsys.net, linux-kernel@vger.kernel.org, Evan Broder , Arnaud Patard , Peter Korsgaard , Sascha Hauer , Rob Clark , Niels de Vos , linux-arm-kernel@lists.infradead.org, blogic@openwrt.org, Pali =?iso-8859-1?Q?Roh=E1r?= Subject: Re: [PATCHv6 2/2] INPUT: Introduce generic trigger/LED pairs to input LEDs Message-ID: <20150211181142.GA29636@amd> References: <20150123122814.GB18514@type.bordeaux.inria.fr> <20150210221105.GC26472@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150210221105.GC26472@dtor-ws> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 2015-02-10 14:11:05, Dmitry Torokhov wrote: > Hi Samuel, > > On Fri, Jan 23, 2015 at 01:28:14PM +0100, Samuel Thibault wrote: > > This permits to reassign input LEDs to something else than keyboard "leds" > > state, by adding a trigger and a led for each input leds, the former being > > triggered by EV_LED events, and the latter being by default triggered by the > > former. The user can then make the LED use another trigger, including other LED > > triggers of the same keyboard. > > > > The hardware LEDs are now not actioned from the EV_LED event any more, but from > > the per-device LED layer. > > > > [ebroder@mokafive.com: Rebased to 3.2-rc1 or so, cleaned up some includes, and fixed some constants] > > [akpm@linux-foundation.org: remove unneeded `extern', fix comment layout] > > Signed-off-by: Samuel Thibault > > Signed-off-by: Evan Broder > > Acked-by: Peter Korsgaard > > Signed-off-by: John Crispin > > Signed-off-by: Andrew Morton > > --- > > Changed in this version: > > - use drvdata instead of platform_data > > - dropped CONFIG_INPUT_LEDS option > > - compacted leds and triggers array allocation > > - handle registration failure > > This did not make the first batch, but I will try to get it into the > 2nd. > > Pavel, have you tried this version? Not really, busy with other stuff, sorry. I promise to test -next once it hits it :-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html