Re: [perf/core PATCH v2 0/4] perf-buildid-cache: Cleanup, enhance --update and add --remove-all

Namhyung Kim
2015-02-10T14:10:18Z

Hi Masami,

On Tue, Feb 10, 2015 at 06:18:49PM +0900, Masami Hiramatsu wrote:
> Hi,
>
> Here is the 2nd version of of perf buildid-cache update.
> I've fixed a bug in patch 4/4 reported by Namhyung, Thanks!
>
> The first 2 patches are cleanup code, just reducing the
> redundant code. The 3rd one modifies --update option not
> to fail but just add new binary if there is no cache entry
> which has same build-id of given binary. The 4th one adds
> --remove-all option which allows us to cleanup all caches
> which related to given path.

For this series,

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung

>
>
> Thank you,
>
>
> ---
>
> Masami Hiramatsu (4):
> perf-buildid-cache: Remove unneeded debugdir parameters
> perf buildid-cache: Consolidate .build-id cache path generators
> perf buildid-cache: Add new buildid cache if update target is not cached
> perf buildid-cache: Add --remove-all FILE to remove all caches of FILE
>
>
> tools/perf/Documentation/perf-buildid-cache.txt | 8 +
> tools/perf/builtin-buildid-cache.c | 85 ++++++++--
> tools/perf/util/build-id.c | 189 +++++++++++++++++------
> tools/perf/util/build-id.h | 6 -
> 4 files changed, 210 insertions(+), 78 deletions(-)
>
> --
> Masami HIRAMATSU
> Software Platform Research Dpt. Linux Technology Center
> Hitachi, Ltd., Yokohama Research Laboratory
> E-mail: masami.hiramatsu.pt@hitachi.com