From: luis@debethencourt.com
To: linux-media@vger.kernel.org
Cc: mchehab@osg.samsung.com, david@hardeman.nu,
james.harper@ejbdigital.com.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dib0700: remove unused macros
Date: Thu, 12 Feb 2015 23:38:26 +0000 [thread overview]
Message-ID: <20150212233826.GA10015@turing> (raw)
In-Reply-To: <20150212221147.GA12614@turing>
On Thu, Feb 12, 2015 at 10:11:47PM +0000, Luis de Bethencourt wrote:
> Remove unused macros RC_REPEAT_DELAY and RC_REPEAT_DELAY_V1_20
>
> Signed-off-by: Luis de Bethencourt <luis.bg@samsung.com>
> ---
> drivers/media/usb/dvb-usb/dib0700_core.c | 3 ---
> drivers/media/usb/dvb-usb/dib0700_devices.c | 3 ---
> 2 files changed, 6 deletions(-)
>
> diff --git a/drivers/media/usb/dvb-usb/dib0700_core.c b/drivers/media/usb/dvb-usb/dib0700_core.c
> index 50856db..2b40393 100644
> --- a/drivers/media/usb/dvb-usb/dib0700_core.c
> +++ b/drivers/media/usb/dvb-usb/dib0700_core.c
> @@ -651,9 +651,6 @@ out:
> return ret;
> }
>
> -/* Number of keypresses to ignore before start repeating */
> -#define RC_REPEAT_DELAY_V1_20 10
> -
> /* This is the structure of the RC response packet starting in firmware 1.20 */
> struct dib0700_rc_response {
> u8 report_id;
> diff --git a/drivers/media/usb/dvb-usb/dib0700_devices.c b/drivers/media/usb/dvb-usb/dib0700_devices.c
> index e1757b8..d7d55a2 100644
> --- a/drivers/media/usb/dvb-usb/dib0700_devices.c
> +++ b/drivers/media/usb/dvb-usb/dib0700_devices.c
> @@ -510,9 +510,6 @@ static int stk7700ph_tuner_attach(struct dvb_usb_adapter *adap)
>
> static u8 rc_request[] = { REQUEST_POLL_RC, 0 };
>
> -/* Number of keypresses to ignore before start repeating */
> -#define RC_REPEAT_DELAY 6
> -
> /*
> * This function is used only when firmware is < 1.20 version. Newer
> * firmwares use bulk mode, with functions implemented at dib0700_core,
> --
> 2.1.0
>
For some context, the only usage of macro RC_REPEAT_DELAY_V1_20 was removed in
commit 72b393106bddc9f0a1ab502b4c8c5793a0441a30
And the last usage of macro RC_REPEAT_DELAY was removed in commit
72b393106bddc9f0a1ab502b4c8c5793a0441a30
Thanks,
Luis
prev parent reply other threads:[~2015-02-12 23:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 22:11 [PATCH] dib0700: remove unused macros Luis de Bethencourt
2015-02-12 23:38 ` luis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150212233826.GA10015@turing \
--to=luis@debethencourt.com \
--cc=david@hardeman.nu \
--cc=james.harper@ejbdigital.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox