From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752646AbbBMI1e (ORCPT ); Fri, 13 Feb 2015 03:27:34 -0500 Received: from mail-pd0-f182.google.com ([209.85.192.182]:40965 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752292AbbBMI1c (ORCPT ); Fri, 13 Feb 2015 03:27:32 -0500 Date: Fri, 13 Feb 2015 13:57:20 +0530 From: Sudip Mukherjee To: Tolga Ceylan Cc: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald , Greg Kroah-Hartman , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] Staging: iio: meter: ade7854-i2c: code style improvements Message-ID: <20150213082720.GA6088@sudip-PC> References: <1423810186-28774-1-git-send-email-tolga.ceylan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423810186-28774-1-git-send-email-tolga.ceylan@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 12, 2015 at 10:49:46PM -0800, Tolga Ceylan wrote: > Code reformatting based on checkpatch.pl with --strict: > 1) Lines over 80 characters were fixed > 2) Alignment should match open paranthesis cases corrected > 3) Comparison to NULL rewritten as !indio_dev you are doing three different types of changes here. one patch should have only one type of change. regards sudip > > Signed-off-by: Tolga Ceylan > --- > drivers/staging/iio/meter/ade7854-i2c.c | 39 +++++++++++++++++---------------- > 1 file changed, 20 insertions(+), 19 deletions(-) > >