From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tolga Ceylan <tolga.ceylan@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"David S. Miller" <davem@davemloft.net>,
Dilek Uzulmez <dilekuzulmez@gmail.com>,
Ning Zhou <zhou.ning.gd@gmail.com>,
Gulsah Kose <gulsah.1004@gmail.com>, Tom Gundersen <teg@jklm.no>,
Scott Weir <sjw0410@gmail.com>,
Monam Agarwal <monamagarwal123@gmail.com>,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
Uma Sharma <uma.sharma523@gmail.com>,
Josh Triplett <josh@joshtriplett.org>,
Daniel Ngu <daniel.dy.ngu@gmail.com>,
Robert Nachlinger <robert.nachlinger@gmail.com>,
Ebru Akagunduz <ebru.akagunduz@gmail.com>,
Octavian Purdila <octavian.purdila@intel.com>,
Kiran Padwal <kiran.padwal21@gmail.com>,
Alexey Khoroshilov <khoroshilov@ispras.ru>,
Aybuke Ozdemir <aybuke.147@gmail.com>,
Cihangir Akturk <cakturk@gmail.com>,
Abel Moyo <abelmoyo.ab@gmail.com>,
Himangi Saraogi <himangi774@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Staging: gdm724x: code style improvements
Date: Fri, 13 Feb 2015 12:05:43 +0300 [thread overview]
Message-ID: <20150213090543.GE5155@mwanda> (raw)
In-Reply-To: <1423817763-32214-1-git-send-email-tolga.ceylan@gmail.com>
On Fri, Feb 13, 2015 at 12:56:03AM -0800, Tolga Ceylan wrote:
> Corrections based on checkpatch.pl with --strict.
> 1) Lines over 80 were corrected
> 2) Alignment should match open paranthesis cases corrected
> 3) Comparisons such as if (x == NULL) rewritten as if (!x)
> 4) CamelCase variables renamed
> 5) Missing spaces between operators added
> 6) Unnecessary blank lines removed
> 7) in mem alloc arguments sizeof(struct foo) rewritten as sizeof(*foo_obj)
>
You're doing too many things at one. This should probably be split into
7 patches.
> u16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x)
> @@ -39,7 +38,7 @@ u16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x)
> if (ed->dev_ed == ed->host_ed)
> return x;
>
> - return Endian16_Swap(x);
> + return ENDIAN16_SWAP(x);
> }
All the changes are good except these. We have standard macros
cpu_to_be16()/le16() and back for these.
regards,
dan carpenter
next prev parent reply other threads:[~2015-02-13 9:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 8:56 [PATCH 1/1] Staging: gdm724x: code style improvements Tolga Ceylan
2015-02-13 9:05 ` Dan Carpenter [this message]
2015-02-13 22:07 ` Tolga Ceylan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150213090543.GE5155@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abelmoyo.ab@gmail.com \
--cc=aybuke.147@gmail.com \
--cc=cakturk@gmail.com \
--cc=daniel.dy.ngu@gmail.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=dilekuzulmez@gmail.com \
--cc=ebru.akagunduz@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gulsah.1004@gmail.com \
--cc=himangi774@gmail.com \
--cc=josh@joshtriplett.org \
--cc=khoroshilov@ispras.ru \
--cc=kiran.padwal21@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=monamagarwal123@gmail.com \
--cc=octavian.purdila@intel.com \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=robert.nachlinger@gmail.com \
--cc=sjw0410@gmail.com \
--cc=teg@jklm.no \
--cc=tolga.ceylan@gmail.com \
--cc=uma.sharma523@gmail.com \
--cc=zhou.ning.gd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox