From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752775AbbBMJGG (ORCPT <rfc822;w@1wt.eu>);
	Fri, 13 Feb 2015 04:06:06 -0500
Received: from aserp1040.oracle.com ([141.146.126.69]:44269 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751910AbbBMJGA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 13 Feb 2015 04:06:00 -0500
Date: Fri, 13 Feb 2015 12:05:43 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tolga Ceylan <tolga.ceylan@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "David S. Miller" <davem@davemloft.net>,
        Dilek Uzulmez <dilekuzulmez@gmail.com>,
        Ning Zhou <zhou.ning.gd@gmail.com>,
        Gulsah Kose <gulsah.1004@gmail.com>, Tom Gundersen <teg@jklm.no>,
        Scott Weir <sjw0410@gmail.com>,
        Monam Agarwal <monamagarwal123@gmail.com>,
        Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
        Uma Sharma <uma.sharma523@gmail.com>,
        Josh Triplett <josh@joshtriplett.org>,
        Daniel Ngu <daniel.dy.ngu@gmail.com>,
        Robert Nachlinger <robert.nachlinger@gmail.com>,
        Ebru Akagunduz <ebru.akagunduz@gmail.com>,
        Octavian Purdila <octavian.purdila@intel.com>,
        Kiran Padwal <kiran.padwal21@gmail.com>,
        Alexey Khoroshilov <khoroshilov@ispras.ru>,
        Aybuke Ozdemir <aybuke.147@gmail.com>,
        Cihangir Akturk <cakturk@gmail.com>, Abel Moyo <abelmoyo.ab@gmail.com>,
        Himangi Saraogi <himangi774@gmail.com>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Staging: gdm724x: code style improvements
Message-ID: <20150213090543.GE5155@mwanda>
References: <1423817763-32214-1-git-send-email-tolga.ceylan@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1423817763-32214-1-git-send-email-tolga.ceylan@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: ucsinet21.oracle.com [156.151.31.93]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 13, 2015 at 12:56:03AM -0800, Tolga Ceylan wrote:
> Corrections based on checkpatch.pl with --strict.
> 1) Lines over 80 were corrected
> 2) Alignment should match open paranthesis cases corrected
> 3) Comparisons such as if (x == NULL) rewritten as if (!x)
> 4) CamelCase variables renamed
> 5) Missing spaces between operators added
> 6) Unnecessary blank lines removed
> 7) in mem alloc arguments sizeof(struct foo) rewritten as sizeof(*foo_obj)
> 

You're doing too many things at one.  This should probably be split into
7 patches.


>  u16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x)
> @@ -39,7 +38,7 @@ u16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x)
>  	if (ed->dev_ed == ed->host_ed)
>  		return x;
>  
> -	return Endian16_Swap(x);
> +	return ENDIAN16_SWAP(x);
>  }

All the changes are good except these.  We have standard macros
cpu_to_be16()/le16() and back for these.

regards,
dan carpenter