From: Dan Carpenter <dan.carpenter@oracle.com>
To: Cass May <cass@cassm.net>
Cc: lidza.louina@gmail.com, markh@compro.net,
devel@driverdev.osuosl.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dgnc: Use ccflags -y instead of EXTRA_CFLAGS
Date: Sat, 14 Feb 2015 01:25:58 +0300 [thread overview]
Message-ID: <20150213222558.GU5206@mwanda> (raw)
In-Reply-To: <1423857696-17781-1-git-send-email-cass@cassm.net>
On Fri, Feb 13, 2015 at 08:01:36PM +0000, Cass May wrote:
> Correction to syntax error in previous patch version. Apologies.
>
Put that stuff under the --- cut off line and not in the permanent
kernel git log.
Changelog is missing. checkpatch.pl by itself is not sufficient
justification. Why did the authors of checkpatch think this way is
better?
> Signed-off-by: Cass May <cass@cassm.net>
> ---
> drivers/staging/dgnc/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/dgnc/Makefile b/drivers/staging/dgnc/Makefile
> index b69f7b6..a278900 100644
> --- a/drivers/staging/dgnc/Makefile
> +++ b/drivers/staging/dgnc/Makefile
> @@ -1,4 +1,4 @@
> -EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
> +ccflags-y := -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
This isn't the right fix. Is this stuff even needed? Hopefully, not
but please check and resend a different fix.
regards,
dan carpenter
prev parent reply other threads:[~2015-02-13 22:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 20:01 [PATCH v2] dgnc: Use ccflags -y instead of EXTRA_CFLAGS Cass May
2015-02-13 22:25 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150213222558.GU5206@mwanda \
--to=dan.carpenter@oracle.com \
--cc=cass@cassm.net \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox