From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753558AbbBMW0B (ORCPT ); Fri, 13 Feb 2015 17:26:01 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:33477 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752743AbbBMW0A (ORCPT ); Fri, 13 Feb 2015 17:26:00 -0500 Date: Sat, 14 Feb 2015 01:25:58 +0300 From: Dan Carpenter To: Cass May Cc: lidza.louina@gmail.com, markh@compro.net, devel@driverdev.osuosl.org, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] dgnc: Use ccflags -y instead of EXTRA_CFLAGS Message-ID: <20150213222558.GU5206@mwanda> References: <1423857696-17781-1-git-send-email-cass@cassm.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423857696-17781-1-git-send-email-cass@cassm.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 13, 2015 at 08:01:36PM +0000, Cass May wrote: > Correction to syntax error in previous patch version. Apologies. > Put that stuff under the --- cut off line and not in the permanent kernel git log. Changelog is missing. checkpatch.pl by itself is not sufficient justification. Why did the authors of checkpatch think this way is better? > Signed-off-by: Cass May > --- > drivers/staging/dgnc/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/dgnc/Makefile b/drivers/staging/dgnc/Makefile > index b69f7b6..a278900 100644 > --- a/drivers/staging/dgnc/Makefile > +++ b/drivers/staging/dgnc/Makefile > @@ -1,4 +1,4 @@ > -EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\" > +ccflags-y := -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\" This isn't the right fix. Is this stuff even needed? Hopefully, not but please check and resend a different fix. regards, dan carpenter