* [PATCH v2] dgnc: Use ccflags -y instead of EXTRA_CFLAGS
@ 2015-02-13 20:01 Cass May
2015-02-13 22:25 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Cass May @ 2015-02-13 20:01 UTC (permalink / raw)
To: lidza.louina, markh; +Cc: driverdev-devel, devel, linux-kernel, Cass May
Correction to syntax error in previous patch version. Apologies.
Signed-off-by: Cass May <cass@cassm.net>
---
drivers/staging/dgnc/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/Makefile b/drivers/staging/dgnc/Makefile
index b69f7b6..a278900 100644
--- a/drivers/staging/dgnc/Makefile
+++ b/drivers/staging/dgnc/Makefile
@@ -1,4 +1,4 @@
-EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
+ccflags-y := -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
obj-$(CONFIG_DGNC) += dgnc.o
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] dgnc: Use ccflags -y instead of EXTRA_CFLAGS
2015-02-13 20:01 [PATCH v2] dgnc: Use ccflags -y instead of EXTRA_CFLAGS Cass May
@ 2015-02-13 22:25 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2015-02-13 22:25 UTC (permalink / raw)
To: Cass May; +Cc: lidza.louina, markh, devel, driverdev-devel, linux-kernel
On Fri, Feb 13, 2015 at 08:01:36PM +0000, Cass May wrote:
> Correction to syntax error in previous patch version. Apologies.
>
Put that stuff under the --- cut off line and not in the permanent
kernel git log.
Changelog is missing. checkpatch.pl by itself is not sufficient
justification. Why did the authors of checkpatch think this way is
better?
> Signed-off-by: Cass May <cass@cassm.net>
> ---
> drivers/staging/dgnc/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/dgnc/Makefile b/drivers/staging/dgnc/Makefile
> index b69f7b6..a278900 100644
> --- a/drivers/staging/dgnc/Makefile
> +++ b/drivers/staging/dgnc/Makefile
> @@ -1,4 +1,4 @@
> -EXTRA_CFLAGS += -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
> +ccflags-y := -DDG_NAME=\"dgnc-1.3-16\" -DDG_PART=\"40002369_F\"
This isn't the right fix. Is this stuff even needed? Hopefully, not
but please check and resend a different fix.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-13 22:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-13 20:01 [PATCH v2] dgnc: Use ccflags -y instead of EXTRA_CFLAGS Cass May
2015-02-13 22:25 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox