From: Simon Horman <horms@verge.net.au>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Mark Rutland <mark.rutland@arm.com>,
Nicolas Pitre <nico@linaro.org>,
Dave Martin <Dave.Martin@arm.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] ARM: smp: Only expose /sys/.../cpuX/online if hotpluggable
Date: Fri, 13 Feb 2015 18:24:37 -0500 [thread overview]
Message-ID: <20150213232435.GA21924@verge.net.au> (raw)
In-Reply-To: <20150213225704.GF8656@n2100.arm.linux.org.uk>
On Fri, Feb 13, 2015 at 10:57:04PM +0000, Russell King - ARM Linux wrote:
> On Fri, Feb 13, 2015 at 03:20:04PM -0500, Simon Horman wrote:
> > > -static int r8a7779_cpu_disable(unsigned int cpu)
> > > -{
> > > - /* only CPU1->3 have power domains, do not allow hotplug of CPU0 */
> > > - return cpu == 0 ? -EPERM : 0;
> > > -}
> ...
> > Its not clear to me why r8a7779_cpu_disable() has been
> > removed rather than replaced by r8a7779_cpu_can_disable()
>
> This is the default if you don't provide a cpu_disable function, so it
> should be removed irrespective of this patch.
Thanks and agreed.
I'd be quite happy to take such a patch through my tree.
prev parent reply other threads:[~2015-02-13 23:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-13 18:06 [PATCH v2] ARM: smp: Only expose /sys/.../cpuX/online if hotpluggable Stephen Boyd
2015-02-13 20:20 ` Simon Horman
2015-02-13 20:23 ` Stephen Boyd
2015-02-13 20:54 ` Magnus Damm
2015-02-13 20:59 ` Stephen Boyd
2015-02-13 21:44 ` Magnus Damm
2015-02-13 23:01 ` Russell King - ARM Linux
2015-02-14 0:01 ` Stephen Boyd
2015-02-14 10:01 ` Magnus Damm
2015-02-16 15:29 ` Mark Rutland
2015-02-13 22:58 ` Russell King - ARM Linux
2015-02-13 22:57 ` Russell King - ARM Linux
2015-02-13 23:24 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150213232435.GA21924@verge.net.au \
--to=horms@verge.net.au \
--cc=Dave.Martin@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=nico@linaro.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox