From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: fsl-asoc-card: Add snd_soc_of_parse_audio_routing()
Date: Fri, 13 Feb 2015 21:02:46 -0800 [thread overview]
Message-ID: <20150214050245.GA3305@Alpha> (raw)
In-Reply-To: <20150214043153.GC9110@finisterre.sirena.org.uk>
On Sat, Feb 14, 2015 at 01:31:53PM +0900, Mark Brown wrote:
> On Thu, Feb 12, 2015 at 01:30:02PM -0800, Nicolin Chen wrote:
>
> > This patch adds snd_soc_of_parse_audio_routing() to get dapm routes
> > via Device Tree. Because snd_soc_of_parse_audio_routing() overrides
> > dpam_routes, we use snd_soc_dapm_add_routes() to append the original
> > build-in DPCM routes instead of linking them to dpam_routes directly.
>
> It seems better to make the helper function play nicely with existing
> DAPM routes in the card rather than have to rearrange things like this.
Yes, that would be better.
> How about having it just record that it should parse the given property
> when the table in the card is being handleed rather than overwrite that?
You mean adding another pair of dapm_routes with num_dapm_routes for
Device Tree or something like that?
Thanks
Nicolin
next prev parent reply other threads:[~2015-02-14 5:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 21:30 [PATCH] ASoC: fsl-asoc-card: Add snd_soc_of_parse_audio_routing() Nicolin Chen
2015-02-14 4:31 ` Mark Brown
2015-02-14 5:02 ` Nicolin Chen [this message]
2015-02-14 5:32 ` Mark Brown
2015-02-14 5:49 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150214050245.GA3305@Alpha \
--to=nicoleotsuka@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox