From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752793AbbBNFCy (ORCPT ); Sat, 14 Feb 2015 00:02:54 -0500 Received: from mail-pd0-f177.google.com ([209.85.192.177]:36643 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751888AbbBNFCx (ORCPT ); Sat, 14 Feb 2015 00:02:53 -0500 Date: Fri, 13 Feb 2015 21:02:46 -0800 From: Nicolin Chen To: Mark Brown Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: fsl-asoc-card: Add snd_soc_of_parse_audio_routing() Message-ID: <20150214050245.GA3305@Alpha> References: <1423776602-28585-1-git-send-email-nicoleotsuka@gmail.com> <20150214043153.GC9110@finisterre.sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150214043153.GC9110@finisterre.sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 14, 2015 at 01:31:53PM +0900, Mark Brown wrote: > On Thu, Feb 12, 2015 at 01:30:02PM -0800, Nicolin Chen wrote: > > > This patch adds snd_soc_of_parse_audio_routing() to get dapm routes > > via Device Tree. Because snd_soc_of_parse_audio_routing() overrides > > dpam_routes, we use snd_soc_dapm_add_routes() to append the original > > build-in DPCM routes instead of linking them to dpam_routes directly. > > It seems better to make the helper function play nicely with existing > DAPM routes in the card rather than have to rearrange things like this. Yes, that would be better. > How about having it just record that it should parse the given property > when the table in the card is being handleed rather than overwrite that? You mean adding another pair of dapm_routes with num_dapm_routes for Device Tree or something like that? Thanks Nicolin