From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755376AbbBPKb1 (ORCPT ); Mon, 16 Feb 2015 05:31:27 -0500 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:44506 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751579AbbBPKb0 (ORCPT ); Mon, 16 Feb 2015 05:31:26 -0500 Date: Mon, 16 Feb 2015 10:31:22 +0000 From: Charles Keepax To: Bo Shen Cc: Mark Brown , Manuel Lauss , Liam Girdwood , Richard Purdie , patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ASoC: wm8731: let codec to manage clock by itself Message-ID: <20150216103122.GA1091@opensource.wolfsonmicro.com> References: <1423121713-19434-1-git-send-email-voice.shen@atmel.com> <54DC62EA.5030503@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54DC62EA.5030503@atmel.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 12, 2015 at 04:23:06PM +0800, Bo Shen wrote: > Hi All, > > On 02/05/2015 03:35 PM, Bo Shen wrote: >> Let the wm8731 codec to manage clock by itself. >> >> Signed-off-by: Bo Shen >> --- >> >> sound/soc/codecs/wm8731.c | 28 ++++++++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) > > Any comments for this patch (aka ping?) I preferred the idea of having the clock as optional and from the discussion on the last patch it didn't look too tricky to achieve. OTOH I think the Atmel system is the only one that uses both this CODEC and common clock so it doesn't look like this would cause any problems, but might be nice for this not to be one more thing for someone to fix up when moving a system to common clock. Thanks, Charles