From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755686AbbBPMvl (ORCPT ); Mon, 16 Feb 2015 07:51:41 -0500 Received: from mail-wi0-f172.google.com ([209.85.212.172]:56552 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754066AbbBPMvk (ORCPT ); Mon, 16 Feb 2015 07:51:40 -0500 Date: Mon, 16 Feb 2015 12:51:34 +0000 From: Lee Jones To: Kiran Padwal Cc: Samuel Ortiz , linux-kernel@vger.kernel.org, Kiran Padwal Subject: Re: [PATCH] mfd: intel_soc_pmic: Add missing error check for devm_kzalloc Message-ID: <20150216125134.GD14545@x1> References: <1423649450-11294-1-git-send-email-kiran.padwal@smartplayin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1423649450-11294-1-git-send-email-kiran.padwal@smartplayin.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Feb 2015, Kiran Padwal wrote: > This patch add a missing check on the return value of devm_kzalloc, > which would cause a NULL pointer dereference in a OOM situation. > > Signed-off-by: Kiran Padwal > --- > drivers/mfd/intel_soc_pmic_core.c | 3 +++ > 1 file changed, 3 insertions(+) Applied, thanks. > diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c > index df7b064..80cef04 100644 > --- a/drivers/mfd/intel_soc_pmic_core.c > +++ b/drivers/mfd/intel_soc_pmic_core.c > @@ -64,6 +64,9 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c, > config = (struct intel_soc_pmic_config *)id->driver_data; > > pmic = devm_kzalloc(dev, sizeof(*pmic), GFP_KERNEL); > + if (!pmic) > + return -ENOMEM; > + > dev_set_drvdata(dev, pmic); > > pmic->regmap = devm_regmap_init_i2c(i2c, config->regmap_config); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog