From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755834AbbBPOhK (ORCPT ); Mon, 16 Feb 2015 09:37:10 -0500 Received: from mail-wi0-f177.google.com ([209.85.212.177]:52268 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753001AbbBPOhI (ORCPT ); Mon, 16 Feb 2015 09:37:08 -0500 Date: Mon, 16 Feb 2015 14:37:03 +0000 From: Lee Jones To: micky_ching@realsil.com.cn Cc: sameo@linux.intel.com, devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, rogerable@realtek.com, wei_wang@realsil.com.cn Subject: Re: [RESEND PATCH v2 8/9] mfd: rtsx: add support for rts525A Message-ID: <20150216143703.GN14545@x1> References: <80af722c3af9b134646c6f50d8db79bb2de3e7e2.1421911636.git.micky_ching@realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <80af722c3af9b134646c6f50d8db79bb2de3e7e2.1421911636.git.micky_ching@realsil.com.cn> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Jan 2015, micky_ching@realsil.com.cn wrote: > From: Micky Ching > > add support for new chip rts525A. > > Signed-off-by: Micky Ching > --- > drivers/mfd/rts5249.c | 104 ++++++++++++++++++++++++++++++++++++++++++- > drivers/mfd/rtsx_pcr.c | 13 ++++-- > drivers/mfd/rtsx_pcr.h | 1 + > include/linux/mfd/rtsx_pci.h | 15 +++++++ > 4 files changed, 129 insertions(+), 4 deletions(-) > > diff --git a/drivers/mfd/rts5249.c b/drivers/mfd/rts5249.c > index 97dde92..134e03f 100644 > --- a/drivers/mfd/rts5249.c > +++ b/drivers/mfd/rts5249.c > @@ -97,7 +97,7 @@ static void rtsx_base_force_power_down(struct rtsx_pcr *pcr, u8 pm_state) > rtsx_pci_write_register(pcr, AUTOLOAD_CFG_BASE + 3, 0x01, 0); > > if (pm_state == HOST_ENTER_S3) { > - if (PCI_PID(pcr) == 0x524A) > + if (PCI_PID(pcr) == 0x524A || PCI_PID(pcr) == 0x525A) Please consider holding a pm_ctrl_reg attribute in the device data structure, then only doing this once during initialisation. Other than that, I have the same comments as before. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog