From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755514AbbBPRPM (ORCPT ); Mon, 16 Feb 2015 12:15:12 -0500 Received: from pmta2.delivery1.ore.mailhop.org ([54.149.155.156]:48677 "EHLO pmta2.delivery1.ore.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753948AbbBPRPK (ORCPT ); Mon, 16 Feb 2015 12:15:10 -0500 X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 104.193.169.186 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX1+WFwFGXln/mF27A4polw1W Date: Mon, 16 Feb 2015 09:10:31 -0800 From: Tony Lindgren To: Robert ABEL Cc: khilman@deeprootsystems.com, linux@arm.linux.org.uk, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] ARM OMAP2+ GPMC: always program GPMCFCLKDIVIDER Message-ID: <20150216171030.GS2531@atomide.com> References: <1424101741-24152-1-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424101741-24152-2-git-send-email-rabel@cit-ec.uni-bielefeld.de> <1424101741-24152-3-git-send-email-rabel@cit-ec.uni-bielefeld.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424101741-24152-3-git-send-email-rabel@cit-ec.uni-bielefeld.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Robert ABEL [150216 07:52]: > GPMC uses GPMCFCLKDIVIDER during synchronous as well as asynchronous accesses > in conjunction with WAITMONITORINGTIME. Thus, it's wrong to only program it for > synchronous accesses. Remove the conditional. Do you have some test case that gets fixed by this? Or does this fix some regression? The reason why I'm asking is that AFAIK we've had async access working all along? Reagrds, Tony > Signed-off-by: Robert ABEL > --- > arch/arm/mach-omap2/gpmc.c | 15 +++++---------- > 1 file changed, 5 insertions(+), 10 deletions(-) > > diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c > index 5c3639c..bae4a20 100644 > --- a/arch/arm/mach-omap2/gpmc.c > +++ b/arch/arm/mach-omap2/gpmc.c > @@ -382,19 +382,14 @@ int gpmc_cs_set_timings(int cs, const struct gpmc_timings *t) > if (gpmc_capability & GPMC_HAS_WR_ACCESS) > GPMC_SET_ONE(GPMC_CS_CONFIG6, 24, 28, wr_access); > > - /* caller is expected to have initialized CONFIG1 to cover > - * at least sync vs async > - */ > l = gpmc_cs_read_reg(cs, GPMC_CS_CONFIG1); > - if (l & (GPMC_CONFIG1_READTYPE_SYNC | GPMC_CONFIG1_WRITETYPE_SYNC)) { > #ifdef DEBUG > - printk(KERN_INFO "GPMC CS%d CLK period is %lu ns (div %d)\n", > - cs, (div * gpmc_get_fclk_period()) / 1000, div); > + printk(KERN_INFO "GPMC CS%d CLK period is %lu ns (div %d)\n", > + cs, (div * gpmc_get_fclk_period()) / 1000, div); > #endif > - l &= ~0x03; > - l |= (div - 1); > - gpmc_cs_write_reg(cs, GPMC_CS_CONFIG1, l); > - } > + l &= ~0x03; > + l |= (div - 1); > + gpmc_cs_write_reg(cs, GPMC_CS_CONFIG1, l); > > gpmc_cs_bool_timings(cs, &t->bool_timings); > > -- > 2.3.0 >