From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Joseph Kogut <joseph.kogut@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, Felipe Balbi <balbi@ti.com>,
USB list <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc3: Moved PCI IDS to linux/pci_ids.h
Date: Mon, 16 Feb 2015 11:39:17 -0800 [thread overview]
Message-ID: <20150216193917.GA9296@kroah.com> (raw)
In-Reply-To: <CAMWSM7i_MBuy08+6uh+FBAz9w0cfHVFRKGRhHKtHSjDM6gKo6g@mail.gmail.com>
On Mon, Feb 16, 2015 at 09:27:09AM -0700, Joseph Kogut wrote:
> It seems that the Synopsys vendor ID is used in usb/dwc2 as well, and
> the rest of the definitions aren't referenced outside of usb/dwc3.
> Would the proper approach be to move the Synopsys vendor ID to
> linux/pci_ids.h, remove the redefinition in usb/dwc2, and remove the
> fixme?
That sounds like the "correct" fix for this.
prev parent reply other threads:[~2015-02-16 19:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 0:17 [PATCH] usb: dwc3: Moved PCI IDS to linux/pci_ids.h Joseph Kogut
2015-02-16 14:59 ` Bjorn Helgaas
2015-02-16 16:27 ` Joseph Kogut
2015-02-16 19:39 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150216193917.GA9296@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@ti.com \
--cc=bhelgaas@google.com \
--cc=joseph.kogut@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox