From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933816AbbBQLGB (ORCPT ); Tue, 17 Feb 2015 06:06:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39677 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933801AbbBQLGA (ORCPT ); Tue, 17 Feb 2015 06:06:00 -0500 Date: Tue, 17 Feb 2015 12:04:05 +0100 From: Oleg Nesterov To: Borislav Petkov Cc: riel@redhat.com, dave.hansen@linux.intel.com, sbsiddha@gmail.com, luto@amacapital.net, tglx@linutronix.de, mingo@kernel.org, hpa@zytor.com, fenghua.yu@intel.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/8] x86,fpu: use disable_task_lazy_fpu_restore helper Message-ID: <20150217110405.GC22233@redhat.com> References: <1423252925-14451-1-git-send-email-riel@redhat.com> <1423252925-14451-8-git-send-email-riel@redhat.com> <20150217090041.GB9784@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150217090041.GB9784@pd.tnic> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/17, Borislav Petkov wrote: > > On Fri, Feb 06, 2015 at 03:02:04PM -0500, riel@redhat.com wrote: > > From: Rik van Riel > > > > Replace magic assignments of fpu.last_cpu = ~0 with more explicit > > disable_task_lazy_fpu_restore calls. > > > > This also fixes the lazy FPU restore disabling in drop_fpu, which > > only really works when !use_eager_fpu(). This is fine for now, > > because fpu_lazy_restore() is only used when !use_eager_fpu() > > currently, but we may want to expand that. > > Sorry, I can't follow here. The only non-trivial change below is in > arch_dup_task_struct(). Please clarify. I guess Rik forgot to update the changelog ;) Initial version of this patch played with drop_fpu() as well, this part was removed after discussion. So I guess the last sentence in the changelog should go away too. Oleg.