From: Clark Williams <williams@redhat.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
RT <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH RT] rt: add rwsem_is_contended() definition to rwsem_rt.h
Date: Tue, 17 Feb 2015 13:08:57 -0600 [thread overview]
Message-ID: <20150217130857.24e233ea@sluggy> (raw)
In-Reply-To: <20150217100911.GG26177@linutronix.de>
[-- Attachment #1: Type: text/plain, Size: 943 bytes --]
On Tue, 17 Feb 2015 11:09:11 +0100
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> * Clark Williams | 2014-08-27 16:09:28 [-0500]:
>
> >Thomas,
> >
> >The latest btrfs code uses rwsem_is_contended() in the function
> >caching_thread(). On RT systems, include/linux/rwsem.h is replaced with
> >include/linux/rwsem_rt.h which does not provide a definition for
> >rwsem_is_contended(). This commit provides a definition that should
> >work on RT (where the lock is actually an rt_mutex).
>
> I see that I added rwsem_is_contended() in v3.14-rt1 which does:
> |static inline int rwsem_is_contended(struct rw_semaphore *sem)
> |{
> | /* rt_mutex_has_waiters() */
> | return !RB_EMPTY_ROOT(&sem->lock.waiters);
> |}
>
> Do you lack this in kernel prior to v3.14?
>
> Sebastian
Yes, that was the problem. I was back-porting to a 3.10 and was missing
the definition. Sorry for the noise.
Clark
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-02-17 19:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 21:09 [PATCH RT] rt: add rwsem_is_contended() definition to rwsem_rt.h Clark Williams
2015-02-17 10:09 ` Sebastian Andrzej Siewior
2015-02-17 19:08 ` Clark Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150217130857.24e233ea@sluggy \
--to=williams@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox