[next:master 10115/10230] drivers/infiniband/hw/ocrdma/ocrdma_hw.c:1510:6: sparse: symbol 'ocrdma_free_pd_pool' was not declared. Should it be static?

[next:master 10115/10230] drivers/infiniband/hw/ocrdma/ocrdma_hw.c:1510:6: sparse: symbol 'ocrdma_free_pd_pool' was not declared. Should it be static?

[kbuild test robot]

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   c26de6d26435059245babb016acb840d9e0e5d12
commit: 72278f474221abd5c09af5d3a4dff39f9d10948f [10115/10230] RDMA/ocrdma: Move PD resource management to driver.
reproduce:
  # apt-get install sparse
  git checkout 72278f474221abd5c09af5d3a4dff39f9d10948f
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   drivers/infiniband/hw/ocrdma/ocrdma_hw.c:109:15: sparse: cast to restricted __le32
>> drivers/infiniband/hw/ocrdma/ocrdma_hw.c:1510:6: sparse: symbol 'ocrdma_free_pd_pool' was not declared. Should it be static?
   drivers/infiniband/hw/ocrdma/ocrdma_hw.c:1594:34: sparse: cast from restricted __le32
   drivers/infiniband/hw/ocrdma/ocrdma_hw.c:1595:34: sparse: cast from restricted __le32

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

[PATCH next] RDMA/ocrdma: ocrdma_free_pd_pool() can be static

[kbuild test robot]

drivers/infiniband/hw/ocrdma/ocrdma_hw.c:1510:6: sparse: symbol 'ocrdma_free_pd_pool' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 ocrdma_hw.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
index ec4571b..037893a 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
@@ -1507,7 +1507,7 @@ void ocrdma_alloc_pd_pool(struct ocrdma_dev *dev)
 	}
 }
 
-void ocrdma_free_pd_pool(struct ocrdma_dev *dev)
+static void ocrdma_free_pd_pool(struct ocrdma_dev *dev)
 {
 	ocrdma_mbx_dealloc_pd_range(dev);
 	kfree(dev->pd_mgr->pd_norm_bitmap);

RE: [PATCH next] RDMA/ocrdma: ocrdma_free_pd_pool() can be static

[Mitesh Ahuja]

Acked-by: Mitesh Ahuja.

-----Original Message-----
From: kbuild test robot [mailto:fengguang.wu@intel.com] 
Sent: Wednesday, February 18, 2015 9:20 AM
To: Mitesh Ahuja
Cc: kbuild-all@01.org; Roland Dreier; Devesh Sharma; Selvin Xavier; Sean Hefty; Hal Rosenstock; Jes Sorensen; Prarit Bhargava; linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH next] RDMA/ocrdma: ocrdma_free_pd_pool() can be static

drivers/infiniband/hw/ocrdma/ocrdma_hw.c:1510:6: sparse: symbol 'ocrdma_free_pd_pool' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 ocrdma_hw.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
index ec4571b..037893a 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
@@ -1507,7 +1507,7 @@ void ocrdma_alloc_pd_pool(struct ocrdma_dev *dev)
 	}
 }
 
-void ocrdma_free_pd_pool(struct ocrdma_dev *dev)
+static void ocrdma_free_pd_pool(struct ocrdma_dev *dev)
 {
 	ocrdma_mbx_dealloc_pd_range(dev);
 	kfree(dev->pd_mgr->pd_norm_bitmap);

RE: [PATCH next] RDMA/ocrdma: ocrdma_free_pd_pool() can be static

[Mitesh Ahuja]

Acked-by: Mitesh Ahuja <mitesh.ahuja@emulex.com>

-----Original Message-----
From: kbuild test robot [mailto:fengguang.wu@intel.com] 
Sent: Wednesday, February 18, 2015 9:20 AM
To: Mitesh Ahuja
Cc: kbuild-all@01.org; Roland Dreier; Devesh Sharma; Selvin Xavier; Sean Hefty; Hal Rosenstock; Jes Sorensen; Prarit Bhargava; linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: [PATCH next] RDMA/ocrdma: ocrdma_free_pd_pool() can be static

drivers/infiniband/hw/ocrdma/ocrdma_hw.c:1510:6: sparse: symbol 'ocrdma_free_pd_pool' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 ocrdma_hw.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
index ec4571b..037893a 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
@@ -1507,7 +1507,7 @@ void ocrdma_alloc_pd_pool(struct ocrdma_dev *dev)
 	}
 }
 
-void ocrdma_free_pd_pool(struct ocrdma_dev *dev)
+static void ocrdma_free_pd_pool(struct ocrdma_dev *dev)
 {
 	ocrdma_mbx_dealloc_pd_range(dev);
 	kfree(dev->pd_mgr->pd_norm_bitmap);