From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752439AbbBRGll (ORCPT ); Wed, 18 Feb 2015 01:41:41 -0500 Received: from mail-wi0-f176.google.com ([209.85.212.176]:60426 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbbBRGlk (ORCPT ); Wed, 18 Feb 2015 01:41:40 -0500 Date: Wed, 18 Feb 2015 07:41:35 +0100 From: Ingo Molnar To: "Luck, Tony" Cc: Linus Torvalds , linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, Borislav Petkov Subject: Re: [GIT PULL] Fix mcelog regression Message-ID: <20150218064135.GA9832@gmail.com> References: <54e3b9d24385bb413@agluck-desk.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54e3b9d24385bb413@agluck-desk.sc.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Luck, Tony wrote: > Sorry for bypassing normal channels, but this looks like > a trivial regression fix to me, but I'm getting pushback > from my co-maintainer and from Ingo. > > 1. This used to work > 2. Now it doesn't > 3. People have complained > > Previous threads: > https://lkml.org/lkml/2015/1/30/641 > https://lkml.org/lkml/2015/2/11/437 So this fix is perfectly OK to me. The primary thing I objected to (which objection you did not quote!!), was the initial approach, the ugly vendor-specific switch you added: https://lkml.org/lkml/2015/2/9/237 The latest replacement commit you added looks clean - and /dev/mcelog is certainly a legacy we have to keep. Thanks, Ingo