From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752279AbbBRIhE (ORCPT ); Wed, 18 Feb 2015 03:37:04 -0500 Received: from ausc60pc101.us.dell.com ([143.166.85.206]:27025 "EHLO ausc60pc101.us.dell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751213AbbBRIhA (ORCPT ); Wed, 18 Feb 2015 03:37:00 -0500 DomainKey-Signature: s=smtpout; d=dell.com; c=nofws; q=dns; h=X-LoopCount0:X-IronPort-AV:Date:From:To:Cc:Subject: Message-ID:MIME-Version:Content-Type:Content-Disposition: User-Agent; b=TOKbuYEXC5mu3FUpwmJ4r//h98bzcQ9X/SZNArn/dOH7smBiqUMFFPUS GwuMebsC9m9W93Gs7+oUgvo4rLRqPdTKErv0hdJtkV3igSeWYolykHMxU srEkoU5VT+Fhr5qiuM3IOcteCf7rnTBFxWjSPA2w9qPlSVUZTaS0u/XtS 4=; X-LoopCount0: from 10.94.54.68 X-IronPort-AV: E=Sophos;i="5.09,595,1418104800"; d="scan'208";a="756385728" Date: Wed, 18 Feb 2015 03:36:57 -0500 From: Parmeshwr Prasad To: pjones@redhat.com, plagnioj@jcrosoft.com, tomi.valkeinen@ti.com Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] Moved assignment out of if() statement in efifb.c Message-ID: <20150218083654.GD9820@linuxteamdev.amer.dell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch depend on my earlier patchs. Moving assignment out of if() statement. Signed-off-by: Parmeshwr Prasad --- drivers/video/fbdev/efifb.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c index cc1a156..9124ba9 100644 --- a/drivers/video/fbdev/efifb.c +++ b/drivers/video/fbdev/efifb.c @@ -275,11 +275,13 @@ static int efifb_probe(struct platform_device *dev) info->fix = efifb_fix; info->flags = FBINFO_FLAG_DEFAULT | FBINFO_MISC_FIRMWARE; - if ((err = fb_alloc_cmap(&info->cmap, 256, 0)) < 0) { + err = fb_alloc_cmap(&info->cmap, 256, 0); + if (err < 0) { pr_err("efifb: cannot allocate colormap\n"); goto err_unmap; } - if ((err = register_framebuffer(info)) < 0) { + err = register_framebuffer(info); + if (err < 0) { pr_err("efifb: cannot register framebuffer\n"); goto err_fb_dealoc; } -- 1.9.3 -Parmeshwr