public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Gaetan Hug <ghug@induct.be>
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1] fix for pwm-mxs period divider computation
Date: Wed, 18 Feb 2015 13:08:26 +0100	[thread overview]
Message-ID: <20150218120825.GA18576@ulmo> (raw)
In-Reply-To: <1424247536-16476-1-git-send-email-ghug@induct.be>

[-- Attachment #1: Type: text/plain, Size: 810 bytes --]

On Wed, Feb 18, 2015 at 09:18:55AM +0100, Gaetan Hug wrote:
> Hello Thierry,
> 
>    I found a bug in the pwm-mxs.c driver for the i.MX28 platform.
> 
>    The driver computes from the desired period which clock divider it
> should be using. This computation assumes that the link between the
> register value and the actual divider value is raising 2 to the power of
> the registry value.
> 
>     div = 1 << regvalue
> 
>    This is true only for the first 5 values out of 8. Next values are
> 64, 256 and, 1024.
>    This affects only the user only if he requests a period > 0.04369s.

Can you put this description into the commit message of the proper
patch, please?

Also, the subject should be in the following format:

	pwm: mxs: Fix period divider computation

Thanks,
Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

      parent reply	other threads:[~2015-02-18 12:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-18  8:18 [PATCH 0/1] fix for pwm-mxs period divider computation Gaetan Hug
2015-02-18  8:18 ` [PATCH 1/1] fixing " Gaetan Hug
2015-02-18 12:11   ` Thierry Reding
2015-02-18 12:08 ` Thierry Reding [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150218120825.GA18576@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=ghug@induct.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox