From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752210AbbBRQiZ (ORCPT ); Wed, 18 Feb 2015 11:38:25 -0500 Received: from pmta1.delivery10.ore.mailhop.org ([54.149.36.10]:60483 "EHLO pmta1.delivery10.ore.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751824AbbBRQiY (ORCPT ); Wed, 18 Feb 2015 11:38:24 -0500 X-Mail-Handler: DuoCircle Outbound SMTP X-Originating-IP: 104.193.169.186 X-Report-Abuse-To: abuse@duocircle.com (see https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information for abuse reporting information) X-MHO-User: U2FsdGVkX18hgEGGRasTd9DdJ6rjj8FY Date: Wed, 18 Feb 2015 08:33:53 -0800 From: Tony Lindgren To: Pali =?utf-8?B?Um9ow6Fy?= Cc: linux-omap@vger.kernel.org, Kevin Hilman , Aaro Koskinen , Sebastian Reichel , Pavel Machek , linux-kernel@vger.kernel.org, Ivaylo Dimitrov , Nishanth Menon Subject: Re: [PATCH] ARM: dts: Revert disabling of smc91x for n900 Message-ID: <20150218163352.GB32521@atomide.com> References: <20150105230228.GO4081@atomide.com> <201502181619.46278@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201502181619.46278@pali> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Pali Rohár [150218 07:23]: > On Tuesday 06 January 2015 00:02:29 Tony Lindgren wrote: > > Revert "ARM: dts: Disable smc91x on n900 until bootloader > > dependency is removed". We've now fixed the issues that > > caused problems with uninitialized hardware depending on > > the bootloader version. Mostly things got fixed with > > the following commits: > > > > 9a894953a97b ("ARM: dts: Fix bootloader version dependencies > > by muxing n900 smc91x pins") 7d2911c43815 ("net: smc91x: Fix > > gpios for device tree based booting") > > > > Note that this only affects the early development boards > > with Ethernet that we still have in a few automated boot > > test systems. > > > > Signed-off-by: Tony Lindgren > > > > --- a/arch/arm/boot/dts/omap3-n900.dts > > +++ b/arch/arm/boot/dts/omap3-n900.dts > > @@ -702,9 +702,6 @@ > > > > ethernet@gpmc { > > compatible = "smsc,lan91c94"; > > - > > - status = "disabled"; > > - > > interrupt-parent = <&gpio2>; > > interrupts = <22 IRQ_TYPE_LEVEL_HIGH>; /* gpio54 */ > > reg = <1 0x300 0xf>; /* 16 byte IO range at offset 0x300 > > */ > > Hello Tony, > > to make smc ethernet working in n900 qemu I needed to apply this patch: > > diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts > index ff36fbe..d96eeb8 100644 > --- a/arch/arm/boot/dts/omap3-n900.dts > +++ b/arch/arm/boot/dts/omap3-n900.dts > @@ -770,7 +770,8 @@ > compatible = "smsc,lan91c94"; > interrupt-parent = <&gpio2>; > interrupts = <22 IRQ_TYPE_LEVEL_HIGH>; /* gpio54 */ > - reg = <1 0x300 0xf>; /* 16 byte IO range at offset 0x300 */ > +// reg = <1 0x300 0xf>; /* 16 byte IO range at offset 0x300 */ > + reg = <1 0x0 0xf>; /* 16 byte IO range at offset 0x300 */ > bank-width = <2>; > pinctrl-names = "default"; > pinctrl-0 = <ðernet_pins>; Oh cool, the 0x300 offset is there mostly to suppress warnings about non-standard location. > With this patch I see in dmesg: > > [ 20.577911] smc91x 2000000.ethernet (unnamed net_device) (uninitialized): smc91x: smc_probe > [ 20.580535] smc91x 2000000.ethernet (unnamed net_device) (uninitialized): smc91x: bank signature probe > returned 0x3300 > [ 20.585327] smc91x 2000000.ethernet (unnamed net_device) (uninitialized): smc91x: revision = 0x3391 > [ 20.590087] smc91x.c: v1.1, sep 22 2004 by Nicolas Pitre > [ 20.593627] smc91x 2000000.ethernet (unnamed net_device) (uninitialized): smc_reset > [ 20.596832] smc91x 2000000.ethernet (unnamed net_device) (uninitialized): smc_phy_detect > [ 20.611938] smc91x 2000000.ethernet (unnamed net_device) (uninitialized): smc91x: smc_shutdown > [ 20.615875] smc91x 2000000.ethernet eth0: SMC91C11xFD (rev 1) at d08be000 IRQ 166 > [ 20.618682] > [ 20.621124] smc91x 2000000.ethernet eth0: Ethernet addr: 52:54:00:12:34:56 > [ 20.624938] smc91x 2000000.ethernet eth0: No PHY found > > (and eth0 exists in ifconfig) > > If I do not apply my patch I got this error message: > > [ 22.134704] smc91x 2000300.ethernet (unnamed net_device) (uninitialized): smc91x: bank signature probe > returned 0x0000 > [ 22.140014] smc91x: not found (-19). > > and no ethernet device was registered. > > With 2.6.28 kernel with N900 patches (but smc91x is unmodified!) ethernet device is working fine. OK that's good news. Care to do a patch to set the offset 0x0 with added comment that qemu needs it? I'll test to make sure it works on the real hardware as well. Regards, Tony