Re: [PATCH] ARM: dts: Revert disabling of smc91x for n900

Pali Rohár
2015-02-18T22:52:21Z

[-- Attachment #1: Type: Text/Plain, Size: 1781 bytes --]

On Wednesday 18 February 2015 23:42:06 Tony Lindgren wrote:
> * Pali Rohár <pali.rohar@gmail.com> [150218 11:07]:
> > On Wednesday 18 February 2015 17:33:53 Tony Lindgren wrote:
> > > > */ +// reg = <1 0x300 0xf>; /* 16 byte IO range
at
> >
> > offset
> >
> > > > 0x300 */ + reg = <1 0x0 0xf>; /* 16 byte IO
range
> >
> > at
> >
> > > > offset 0x300 */
> > > >
> > > > bank-width = <2>;
> > > > pinctrl-names = "default";
> > > > pinctrl-0 = <&ethernet_pins>;
> > >
> > > Oh cool, the 0x300 offset is there mostly to suppress
> > > warnings about non-standard location.
>
> ...
>
> > > OK that's good news. Care to do a patch to set the offset
> > > 0x0 with added comment that qemu needs it? I'll test to
> > > make sure it works on the real hardware as well.
> >
> > Yes, I can send proper git format-patch, but first let me
> > know if that change does not break your HW...
>
> Yes using reg = <1 0 0xf> works, it just adds this extra
> warning:
>
> smc91x 2000000.ethernet (unnamed net_device) (uninitialized):
> smc91x: IOADDR d09d6000 doesn't match configuration (300).
>
> And I'm pretty sure that can be fixed by setting the EEPROM
> offset to 0 instead of the default 0x300. People with smc91x
> most likely want to write at least the MAC address to the
> EEPROM, so might as well set the offset to zero then too.
>
> Of course it's always possible to do do a omap3-n900-qemu.dts
> if larger changes are needed :)
>
> Regards,
>
> Tony

I would like to avoid using separate DTS for qemu. When we have
only one DTS file (for both qemu and real HW), we can test for
regression in qemu and we are sure that we have same software
configuration...