From: Andi Kleen <andi@firstfloor.org>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>, "H. Peter Anvin" <hpa@zytor.com>,
Akinobu Mita <akinobu.mita@gmail.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Andi Kleen <andi@firstfloor.org>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-usb@vger.kernel.org, stable <stable@vger.kernel.org>,
torvalds@linux-foundation.org
Subject: Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned
Date: Wed, 18 Feb 2015 21:39:09 +0100 [thread overview]
Message-ID: <20150218203909.GE13991@two.firstfloor.org> (raw)
In-Reply-To: <1424290743.9530.122.camel@schen9-desk2.jf.intel.com>
> > Have you tried doing the experiments I suggested in
> >
> > http://marc.info/?l=linux-usb&m=142272448620716&w=2
> >
> > to determine where the problem occurs?
> >
>
> I was bogged down with other things lately and I haven't got a chance to
> test that. But as you said, there's very few places where xhci
> call this memory allocation. So I think the problem has been fairly
> narrowed down for the XHCI folks.
Also I don't really understand why we're even discussing this. The patch
only makes an widely used API behave as it was before. Who knows who
else was broken with this change. There's no sane way to audit all
users. There is no real advantage of the new behavior.
The only good way is to revert to old behavior, like in Tim's
original patch. And doing it quickly for mainline and stable.
FWIW we have a large number of systems here that are broken
without this change.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2015-02-18 20:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 19:54 [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned Tim Chen
2015-01-30 19:58 ` Greg KH
2015-01-30 22:01 ` Tim Chen
2015-01-30 22:07 ` Greg KH
2015-01-30 22:16 ` Tim Chen
2015-01-30 22:39 ` Andi Kleen
2015-01-31 17:14 ` Alan Stern
2015-01-30 21:03 ` Sergei Shtylyov
2015-01-30 21:54 ` Tim Chen
2015-02-02 14:02 ` Jiri Slaby
2015-02-02 16:39 ` Sergei Shtylyov
2015-02-04 18:30 ` Tim Chen
2015-02-18 19:40 ` Tim Chen
2015-02-18 19:53 ` Alan Stern
2015-02-18 20:19 ` Tim Chen
2015-02-18 20:36 ` Greg Kroah-Hartman
2015-02-18 20:39 ` Andi Kleen [this message]
2015-02-18 21:15 ` Alan Stern
2015-02-18 20:45 ` Alan Stern
2015-02-18 23:59 ` Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150218203909.GE13991@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mathias.nyman@linux.intel.com \
--cc=mingo@elte.hu \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox