From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752478AbbBRWG4 (ORCPT ); Wed, 18 Feb 2015 17:06:56 -0500 Received: from mail-wg0-f53.google.com ([74.125.82.53]:43779 "EHLO mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752069AbbBRWGz (ORCPT ); Wed, 18 Feb 2015 17:06:55 -0500 Date: Wed, 18 Feb 2015 23:06:50 +0100 From: Ingo Molnar To: Alexander Kuleshov Cc: Thomas Gleixner , "H. Peter Anvin" , Martin Mares , Ingo Molnar , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] x86: loadflags cleanups Message-ID: <20150218220650.GA28460@gmail.com> References: <1422685925-6003-1-git-send-email-kuleshovmail@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1422685925-6003-1-git-send-email-kuleshovmail@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Alexander Kuleshov wrote: > There are a couple macros in the arch/x86/include/uapi/asm/bootparam.h > for checking loadflags bits. Let's use it instead of shifting bits > > Alexander Kuleshov (2): > x86: use already defined KEEP_SEGMENTS macro from bootparam.h > x86/boot: use already defined KEEP_SEGMENTS macro in head_{32,64}.S > > arch/x86/boot/compressed/head_32.S | 5 +++-- > arch/x86/boot/compressed/head_64.S | 3 ++- > arch/x86/kernel/head_32.S | 7 ++++--- > 3 files changed, 9 insertions(+), 6 deletions(-) I think a single patch would be perfectly fine for a cleanup that does the same thing in three files. Thanks, Ingo