From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Andrey Tsyvarev <tsyvarev@ispras.ru>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] kernel/module.c: Free lock-classes if parse_args failed
Date: Thu, 19 Feb 2015 01:12:33 +0100 [thread overview]
Message-ID: <20150219001233.GC10076@gmail.com> (raw)
In-Reply-To: <20150120094805.GB11596@twins.programming.kicks-ass.net>
* Peter Zijlstra <peterz@infradead.org> wrote:
> On Tue, Jan 20, 2015 at 05:07:19PM +1030, Rusty Russell wrote:
> > Andrey Tsyvarev <tsyvarev@ispras.ru> writes:
> > > parse_args call module parameters' .set handlers, which may use locks defined in the module.
> > > So, these classes should be freed in case parse_args returns error(e.g. due to incorrect parameter passed).
> >
> > Thanks, this seems right. Applied.
> >
> > But this makes me ask: where is lockdep_free_key_range() called on the
> > module init code? It doesn't seem to be at all...
>
> Hmm, Ingo, how does this work? The lockless class lookup in
> look_up_lock_class() very much assumes the class hash is only added too,
> but here we go wipe stuff from it.
>
> From what I can tell, every use of lockdep_free_key_range() is broken.
indeed ...
Thanks,
Ingo
next prev parent reply other threads:[~2015-02-19 0:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 6:25 [PATCH] kernel/module.c: Free lock-classes if parse_args failed Andrey Tsyvarev
2015-01-20 6:37 ` Rusty Russell
2015-01-20 7:47 ` Andrey Tsyvarev
2015-01-21 1:40 ` Rusty Russell
2015-01-21 10:49 ` Andrey Tsyvarev
2015-01-22 0:40 ` Rusty Russell
2015-01-22 9:27 ` Andrey Tsyvarev
2015-01-20 9:48 ` Peter Zijlstra
2015-02-19 0:12 ` Ingo Molnar [this message]
2015-02-19 11:57 ` Peter Zijlstra
2015-02-19 12:24 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150219001233.GC10076@gmail.com \
--to=mingo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rusty@rustcorp.com.au \
--cc=tsyvarev@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox