* [PATCH 1/1] Staging: i2o: i2o_scsi: Fixed coding style issue
@ 2015-02-19 0:45 Tolga Ceylan
2015-02-19 6:28 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Tolga Ceylan @ 2015-02-19 0:45 UTC (permalink / raw)
To: Greg Kroah-Hartman, Christoph Hellwig, Hannes Reinecke,
Ewan Milne, Alan Cox, devel, linux-kernel, tolga.ceylan
Removed assignment in if condition
Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
---
drivers/staging/i2o/i2o_scsi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/i2o/i2o_scsi.c b/drivers/staging/i2o/i2o_scsi.c
index 1b11dcb..f320366 100644
--- a/drivers/staging/i2o/i2o_scsi.c
+++ b/drivers/staging/i2o/i2o_scsi.c
@@ -750,7 +750,8 @@ static int i2o_scsi_bios_param(struct scsi_device *sdev,
size = capacity;
ip[0] = 64; /* heads */
ip[1] = 32; /* sectors */
- if ((ip[2] = size >> 11) > 1024) { /* cylinders, test for big disk */
+ ip[2] = size >> 11;
+ if (ip[2] > 1024) { /* cylinders, test for big disk */
ip[0] = 255; /* heads */
ip[1] = 63; /* sectors */
ip[2] = size / (255 * 63); /* cylinders */
--
2.3.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] Staging: i2o: i2o_scsi: Fixed coding style issue
2015-02-19 0:45 [PATCH 1/1] Staging: i2o: i2o_scsi: Fixed coding style issue Tolga Ceylan
@ 2015-02-19 6:28 ` Dan Carpenter
2015-02-19 6:31 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2015-02-19 6:28 UTC (permalink / raw)
To: Tolga Ceylan
Cc: Greg Kroah-Hartman, Christoph Hellwig, Hannes Reinecke,
Ewan Milne, Alan Cox, devel, linux-kernel
On Wed, Feb 18, 2015 at 04:45:50PM -0800, Tolga Ceylan wrote:
> Removed assignment in if condition
>
This patch looks good, but it's not really worth cleaning up i2o. We
just moved it to staging to see if anyone noticed that it was gone.
Next kernel release we want to delete it entirely.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] Staging: i2o: i2o_scsi: Fixed coding style issue
2015-02-19 6:28 ` Dan Carpenter
@ 2015-02-19 6:31 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-02-19 6:31 UTC (permalink / raw)
To: Tolga Ceylan
Cc: devel, Greg Kroah-Hartman, linux-kernel, Ewan Milne,
Christoph Hellwig, Hannes Reinecke, Alan Cox
Also you sent three patches with the exact same subject. Don't do that.
The subject should be more specific. Also the word "fix" is sort of
reserved for actual fixes, this is a cleanup. The tutorials all suggest
terrible subjects so everyone makes these mistakes.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-19 6:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-19 0:45 [PATCH 1/1] Staging: i2o: i2o_scsi: Fixed coding style issue Tolga Ceylan
2015-02-19 6:28 ` Dan Carpenter
2015-02-19 6:31 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox