From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tolga Ceylan <tolga.ceylan@gmail.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Ewan Milne <emilne@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
Hannes Reinecke <hare@suse.de>, Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH 1/1] Staging: i2o: i2o_scsi: Fixed coding style issue
Date: Thu, 19 Feb 2015 09:31:53 +0300 [thread overview]
Message-ID: <20150219063153.GD5206@mwanda> (raw)
In-Reply-To: <20150219062805.GC5206@mwanda>
Also you sent three patches with the exact same subject. Don't do that.
The subject should be more specific. Also the word "fix" is sort of
reserved for actual fixes, this is a cleanup. The tutorials all suggest
terrible subjects so everyone makes these mistakes.
regards,
dan carpenter
prev parent reply other threads:[~2015-02-19 6:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 0:45 [PATCH 1/1] Staging: i2o: i2o_scsi: Fixed coding style issue Tolga Ceylan
2015-02-19 6:28 ` Dan Carpenter
2015-02-19 6:31 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150219063153.GD5206@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alan@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=emilne@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tolga.ceylan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox