From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752886AbbBSTE4 (ORCPT ); Thu, 19 Feb 2015 14:04:56 -0500 Received: from mail-we0-f176.google.com ([74.125.82.176]:33139 "EHLO mail-we0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751977AbbBSTEy (ORCPT ); Thu, 19 Feb 2015 14:04:54 -0500 Date: Thu, 19 Feb 2015 20:04:49 +0100 From: Ingo Molnar To: Nicholas Mc Guire Cc: Jonathan Corbet , Ingo Molnar , Peter Zijlstra , Valdis.Kletnieks@vt.edu, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] doc: brief user documentation for completion Message-ID: <20150219190449.GA11889@gmail.com> References: <1422601312-26958-1-git-send-email-der.herr@hofr.at> <20150218224715.GA31461@gmail.com> <20150219132933.GA11636@opentech.at> <20150219065640.35806e4c@lwn.net> <20150219153603.GA8069@opentech.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150219153603.GA8069@opentech.at> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Nicholas Mc Guire wrote: > On Thu, 19 Feb 2015, Jonathan Corbet wrote: > > > On Thu, 19 Feb 2015 14:29:33 +0100 > > Nicholas Mc Guire wrote: > > > > > thanks for the detailed review notes > > > > > > will give it another run regarding locking and context - I obviously need a > > > rerun regarding context and locking my self. > > > > Note that the document went upstream last week, so it would be best to > > get changes as a patch against that version. > > for review I do think it would be best to send it out as > a full text - once the content is acked no issue with > sending it out as a patch to the current version. That would be fine to me. You could do both: send the full text, attach the diff at the end. Thanks, Ingo