From: Steven Rostedt <rostedt@goodmis.org>
To: Adrien Schildknecht <adrien+dev@schischi.me>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, heukelum@fastmail.fm, luto@amacapital.net,
adech.fo@gmail.com, masami.hiramatsu.pt@hitachi.com,
akpm@linux-foundation.org, a.ryabinin@samsung.com,
fruggeri@arista.com, bp@alien8.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86: fix output of show_stack_log_lvl()
Date: Thu, 19 Feb 2015 23:45:48 -0500 [thread overview]
Message-ID: <20150219234548.2e4412cb@grimm.local.home> (raw)
In-Reply-To: <1424399661-20327-1-git-send-email-adrien+dev@schischi.me>
On Fri, 20 Feb 2015 03:34:21 +0100
Adrien Schildknecht <adrien+dev@schischi.me> wrote:
> show_stack_log_lvl() does not set the log level after a new line,
> the following messages printed with pr_cont are thus assigned to the
> default log level.
This looks like a bug in printk(). Why doesn't pr_cont() continue? It
shouldn't care if there's a newline or not. pr_cont() is supposed to
continue whatever the last printk log level was.
If this is broken here, it's probably broken elsewhere. The fix is to
fix printk, not to hunt and peck for the places with work arounds that
are broken by it.
-- Steve
> This patch prepends the log level to the next message following a new
> line.
>
> print_trace_address() uses printk(log_lvl). Using printk with just
> a log level is ignored and thus has no effect on the next pr_cont.
> We need to prepend the log level directly into the message.
>
> Signed-off-by: Adrien Schildknecht <adrien+dev@schischi.me>
next prev parent reply other threads:[~2015-02-20 4:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 22:43 [PATCH 0/2] x86: fix output of show_stack_log_lvl Adrien Schildknecht
2015-02-19 22:43 ` [PATCH 1/2] x86: fix output of show_stack_log_lvl() Adrien Schildknecht
2015-02-20 0:06 ` Borislav Petkov
2015-02-19 22:43 ` [PATCH 2/2] x86: fix output of show_trace_log_lvl() Adrien Schildknecht
2015-02-20 2:34 ` [PATCH v2] x86: fix output of show_stack_log_lvl() Adrien Schildknecht
2015-02-20 4:45 ` Steven Rostedt [this message]
[not found] ` <CA+55aFzDt_7Rs9=4XFKo0LP4iBnV4qmJWUDACtBDbV4eRE-X9A@mail.gmail.com>
2015-02-20 17:05 ` Steven Rostedt
2015-02-20 17:35 ` Borislav Petkov
2015-02-20 17:40 ` Joe Perches
[not found] ` <CA+55aFx8pcoGzKuTubwzcBc-0=_Eoiu2n=Ub75PDuo8GkZvyng@mail.gmail.com>
2015-02-20 18:03 ` Joe Perches
2015-02-20 18:51 ` Linus Torvalds
2015-02-20 19:15 ` Joe Perches
2015-02-20 8:10 ` Ingo Molnar
2015-02-20 10:38 ` Borislav Petkov
2015-02-20 16:39 ` Adrien Schildknecht
2015-03-03 11:28 ` [tip:x86/debug] x86/kernel: Fix " tip-bot for Adrien Schildknecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150219234548.2e4412cb@grimm.local.home \
--to=rostedt@goodmis.org \
--cc=a.ryabinin@samsung.com \
--cc=adech.fo@gmail.com \
--cc=adrien+dev@schischi.me \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=fruggeri@arista.com \
--cc=heukelum@fastmail.fm \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox