From: Borislav Petkov <bp@alien8.de>
To: Adrien Schildknecht <adrien+dev@schischi.me>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, rostedt@goodmis.org, heukelum@fastmail.fm,
luto@amacapital.net, adech.fo@gmail.com,
masami.hiramatsu.pt@hitachi.com, akpm@linux-foundation.org,
a.ryabinin@samsung.com, fruggeri@arista.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86: fix output of show_stack_log_lvl()
Date: Fri, 20 Feb 2015 01:06:20 +0100 [thread overview]
Message-ID: <20150220000620.GC31467@pd.tnic> (raw)
In-Reply-To: <1424385796-28910-2-git-send-email-adrien+dev@schischi.me>
On Thu, Feb 19, 2015 at 11:43:15PM +0100, Adrien Schildknecht wrote:
> Prepend the log level at the message following a newline.
> It is not possible to use pr_cont after a newline, the log level will be
> reseted.
>
> Signed-off-by: Adrien Schildknecht <adrien+dev@schischi.me>
> ---
> arch/x86/kernel/dumpstack_32.c | 9 ++++++---
> arch/x86/kernel/dumpstack_64.c | 9 ++++++---
> 2 files changed, 12 insertions(+), 6 deletions(-)
So those two patches belong into one as they logically are one fix.
Please merge them.
Then, please change your commit message to the format:
"Problem is A.
We need to do B.
This patch does it or this patch does C in order fix it."
Something like that in free form. Being verbose is a good thing when
explaning why this fix is needed and for people looking at those commit
messages months and years from now.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-02-20 0:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 22:43 [PATCH 0/2] x86: fix output of show_stack_log_lvl Adrien Schildknecht
2015-02-19 22:43 ` [PATCH 1/2] x86: fix output of show_stack_log_lvl() Adrien Schildknecht
2015-02-20 0:06 ` Borislav Petkov [this message]
2015-02-19 22:43 ` [PATCH 2/2] x86: fix output of show_trace_log_lvl() Adrien Schildknecht
2015-02-20 2:34 ` [PATCH v2] x86: fix output of show_stack_log_lvl() Adrien Schildknecht
2015-02-20 4:45 ` Steven Rostedt
[not found] ` <CA+55aFzDt_7Rs9=4XFKo0LP4iBnV4qmJWUDACtBDbV4eRE-X9A@mail.gmail.com>
2015-02-20 17:05 ` Steven Rostedt
2015-02-20 17:35 ` Borislav Petkov
2015-02-20 17:40 ` Joe Perches
[not found] ` <CA+55aFx8pcoGzKuTubwzcBc-0=_Eoiu2n=Ub75PDuo8GkZvyng@mail.gmail.com>
2015-02-20 18:03 ` Joe Perches
2015-02-20 18:51 ` Linus Torvalds
2015-02-20 19:15 ` Joe Perches
2015-02-20 8:10 ` Ingo Molnar
2015-02-20 10:38 ` Borislav Petkov
2015-02-20 16:39 ` Adrien Schildknecht
2015-03-03 11:28 ` [tip:x86/debug] x86/kernel: Fix " tip-bot for Adrien Schildknecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150220000620.GC31467@pd.tnic \
--to=bp@alien8.de \
--cc=a.ryabinin@samsung.com \
--cc=adech.fo@gmail.com \
--cc=adrien+dev@schischi.me \
--cc=akpm@linux-foundation.org \
--cc=fruggeri@arista.com \
--cc=heukelum@fastmail.fm \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox